mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.24k stars 2.94k forks source link

Bugfix FXIOS-10560 - Password Generator: Keyboard Closing After Accessing Pass Gen #23305

Open DanielDervishi opened 13 hours ago

DanielDervishi commented 13 hours ago

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

Added the ability to specify a dismiss completion handler for a bottom sheet. I don't really know how valuable this is for bottomsheets in general, so I could definitely just create a subclass of bottom sheet VC for password generator which overrides dismiss functionality. Some thoughts and feedback on this would be great.

This is also a sort of hacky way of fixing the bug which we may not want to move forward with. It leverages the seemingly auto focusing capabilities that come with reloading the webview for an accessory view in order to show the keyboard again for the password generator.

Also its worth noting that clicking onto another field would not switch to the standard keyboard view, even if its not a keyboard field due to the nature of when accessory views are loaded (pretty sure they have to explicitly be loaded) and I don't believe that the standard accessory view is loaded whenever we focus a non-special field.

:pencil: Checklist

You have to check all boxes before merging