mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.25k stars 2.95k forks source link

Add FaceID/TouchID lock for the whole app #4955

Open user858753257 opened 5 years ago

user858753257 commented 5 years ago

See title . At the moment it is used only for passwords etc..

┆Issue is synchronized with this Jira Task

sindhugudivada commented 5 years ago

@farhanpatel Is this available to grab and work on ? @F3000 what do you mean by "Its only used for passwords at the moment"

user858753257 commented 5 years ago

I mean with passwords , that Faceid locks only the „saved password section“

Bunn commented 5 years ago

How would this work exactly? Currently we have "Passcode For Logins", should we create a new one "Passcode For App" or just merge both of them on the same screen?

If we merge, should we have one toggle for everything or should we add a section for passcode for app and another for passcode for logins?

I'm not sure what's the expected behavior here because both approaches have pros/cons

My suggestion:

[ Enable Passcode ] - section divider Passcode for Logins - ON/OFF Passcode for App - ON/OFF

[ Passcode ] - section divider Change Passcode Require Passcode >

The password would be shared for both actions (Easier to understand) and we have individual toggles for each option, app and logins (enables user's choice). Toggling any toggle OFF would require the password to confirm, just like it's done today. Turning the first toggle ON would require to create the password, just like it's done today Turning the second toggle ON would require the password to confirm (since it's already registered)

Let me know if this makes sense :)

utsavDave97 commented 2 years ago

Is this still active? I would like to contribute.

lmarceau commented 2 years ago

Not sure this is a wanted feature @utsavDave97, this needs to be confirmed by @dnarcese