Spinner showing indefinitely when trying to send and refresh tab from a FxA disconnected state

mozilla-mobile / firefox-ios

Firefox for iOS

Mozilla Public License 2.0

12.21k stars 2.93k forks source link

Spinner showing indefinitely when trying to send and refresh tab from a FxA disconnected state #5482

Closed SimonBasca closed 3 years ago

SimonBasca commented 5 years ago

Logged via: https://bugzilla.mozilla.org/show_bug.cgi?id=1575618

Preconditions:

FxA is in a disconnected stated

Steps to reproduce:

Load a web page
Open Page Action menu
Tap send tab

Actual results:

The spinning throttle is displayed indefinitely.

Expected results:

Firefox iOS code should be fixed to show an error in this case instead of spinning indefinitely.

┆Issue is synchronized with this Jira Task

garvankeeley commented 4 years ago

@SimonBasca any idea how to reproduce this?

SimonBasca commented 4 years ago

@garvankeeley I am unable to reproduce the crash following the STR on 21.0 (16860) but the spinning throttle is still spinning indefinitely after following the STR.

nbhasin2 commented 4 years ago

Gonna take a look at it today and report back.

SimonBasca commented 4 years ago

@nbhasin2 not sure if you are aware of this but you can go to the disconnected state by going to Settings and tapping 3 times on the version number in Firefox. After the debugger options are revealed you can tap on "Debug: require password". Hope this helps.

nbhasin2 commented 4 years ago

@SimonBasca Is this what happens without the crash?

nbhasin2 commented 4 years ago

After more investigation, this happens when account is disconnected or not verified. There is no crash though. The spinner just spins indefinitely but no crash happens.

The ideal thing to do would be adding a message stating the user that the account is in a disconnected / not verified state.

SimonBasca commented 4 years ago

@SimonBasca Is this what happens without the crash?

@nbhasin2 That is also the behavior I am experiencing.

mnoorenberghe commented 4 years ago

FWIW I hit this again today so thanks for taking it!

brampitoyo commented 4 years ago

@nbhasin2 @SimonBasca @mnoorenberghe For this disconnected state, I wonder if we can show the same error message that we show when the user aren’t signed in to FxA? After all, the fix in both states is identical: the user must sign back in.