search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.14k stars 2.91k forks source link

Night mode is inverting photos #5951

Closed AutomatedTester closed 2 years ago

AutomatedTester commented 4 years ago

STR:

  1. Set the browser to dark mode
  2. Visit https://www.arsenal.com/women/players

The team photos show up as negatives 714E1FC6-BBF9-4362-A0E6-A22FD9111633

I am using Version 21.0 (16901) on iPhone 7+

┆Issue is synchronized with this Jira Task

athomasmoz commented 4 years ago

Hi @AutomatedTester thanks for logging. Marking as a P2.

Night mode inverts page colours and looks like it isn't recognizing this as an image. As a workaround until fixed, you can try turning off Night Mode and keeping Dark Theme (setting at system level or in Firefox theme settings). The page will be shown in original colours and just the app skin will be shown dark.

athomasmoz commented 4 years ago

Another issues logged with steps to reproduce is #5799 (closing a dup of this ticket):

Steps to reproduce:

  1. Open the CNN home page.
  2. Long press on an image that is a link.

Expected: Image is shown with correct colors in link preview mode.

Actual Behavior:

• Colors or image are inverted while user long-taps on the image. • When user lets go of the tap, the image stays.

(notice also that the colors of the CNN logo on that page are also inverted. don't have to tap though.)

Originally filed here: https://bugzilla.mozilla.org/show_bug.cgi?id=1598311

minusf commented 3 years ago

can't believe this is a year old. such an annoying basic issue :(

cyclingwithelephants commented 2 years ago

Is this likely to be looked at? I use dark mode as an accessibility feature and this makes Firefox for iOS randomly unusable for me

powerfool commented 2 years ago

Why was his closed? I still get the same issue in iPad with the latest Firefox. https://share.icloud.com/photos/0USBzPugE7_K3Y6ArnHMm1f6w

MXMaddux commented 2 years ago

can't believe this is a year old. such an annoying basic issue :(

I just experienced the same issue with Firefox on my iPhone!

kisabelle commented 2 years ago

Experiencing this issue still. In some cases switching off night mode seems to resolve the issue but I have also found a case where an image was inverted without Night mode turned on - in a before/after photo slider the after photo was inverted.

hgducharme commented 2 years ago

I am experiencing this issue also, very frequently.

JahnSteven commented 2 years ago

Still having this issue 2.5 years later. Even the original steps to reproduce still fail.

Koleon commented 1 year ago

Hello, unfortunately, I experience the same issue.

bert-willekens commented 1 year ago

Hello @dnarcese. Why is this closed? This problem is very actual. Also I hate closing issues without comment in genera. Frustrating.

lmarceau commented 1 year ago

@bert-willekens, there's other tickets opened for this feature. Probably the one you are searching for is here: https://github.com/mozilla-mobile/firefox-ios/issues/5819