search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.21k stars 2.93k forks source link

Receiving sent tab should work without notification opt-in #6526

Open garvankeeley opened 4 years ago

garvankeeley commented 4 years ago

Steps to reproduce

Expected behavior

Actual behavior

Note: sync should be calling https://searchfox.org/mozilla-mobile/source/application-services/components/fxa-client/ios/FxAClient/FxAccountDeviceConstellation.swift#78 pollForCommands, and that should get the sent tab, and the app should show it. This is not yet hooked up.

┆Issue is synchronized with this Jira Task

garvankeeley commented 4 years ago

~@csuciu @SimonBasca can you try this on v24 and v25 and confirm? I am not sure is this is a regression.~ Sync team says this wasn't hooked up properly previously.

eoger commented 4 years ago

cc @rfk @mhammond who might be interested in these things. There's 2 things you want to do here:

This would allow you to recover those missed tabs without hammering the servers too much. Something we talked about with @garvankeeley this morning would be to show UI to the user when we recover a tab and we notice push is off to explain the situation and entice them to enable notifications.

mhammond commented 4 years ago

Anecdotally, I'm not sure the "manual sync" thing is working out that well for us. When reporting problems, a number of users simply don't think to perform a "sync now". If some users who are in contact with us don't do that, I expect the vast majority or regular users wouldn't.

IOW, I think we are kidding ourselves that "manual sync" is a panacea for push not working and I'm wondering if we should be even more aggressive with the periodic polling?

rfk commented 4 years ago

I think we are kidding ourselves that "manual sync" is a panacea for push not working

Definitely not a panacea, but I think it's a valuable fallback for a subset of users who have it in their mental model of the world.

I'm wondering if we should be even more aggressive with the periodic polling?

Probably, but OTOH, we'll have to take a look at that holistically from a service perspective. We don't want to switch to more aggressive polling, discover that the server can't handle the load, and eventually need to re-architect back to a shareded-sync-like architecture for scalability reasons (iIOW we don't want to repeat the story we're currently playing out with webext-storage sync).

zigotica commented 2 years ago

I have the same problem. In my case, it has nothing to do with notification being on/off though (I have it on).

FF nightly 100.0a1 (2022-03-25) (64-bit) FF iOS Daylight 97.0

IME it might have something to do with device names given automatically on app update. Every time I update the app it breaks the feature, no matter how many times I logout, login, sync. After many attempts I managed to make it wrk in past version. But 97 seems broken.

mhammond commented 2 years ago

But 97 seems broken.

iOS had a server-side outage related to sent tabs which should now be resolved. We are also trying to better understand how to improve the reliability independent of this recent problem.

zigotica commented 2 years ago

iOS had a server-side outage related to sent tabs which should now be resolved.

I can confirm it is working now, thank you

We are also trying to better understand how to improve the reliability independent of this recent problem.

Is there a way to check the status of that service? For users to know when another server-side outage occurs and avoid opening another issue here.

Thank you

tarikeshaq commented 1 year ago

This was fixed in 109, we poll for sent tabs on manual "Sync now" and once a day on a scheduled sync

github-actions[bot] commented 7 months ago

This issue has been automatically marked as stale. Has the issue been fixed, or does it still require the community's attention? Please leave any comment to keep this issue opened. It will be closed automatically if no further update occurs in the next 30 days. Thank you for your contributions!

github-actions[bot] commented 6 months ago

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue linking to this one, with up-to-date information. Thank you!