search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.17k stars 2.92k forks source link

Private tab opens amazon links in the amazon app #6717

Open FloMiau opened 4 years ago

FloMiau commented 4 years ago

I could reproduce this only for the amazon app. I tried reinstalling amazon.

Steps to reproduce

1) open firefox in private mode 1) search for something "test amazon" 1) tap on link, e.g. "Amazon test item" (in the video I tapped on the first link)

Expected behavior

Amazon should open in a private tab.

Actual behavior

Firefox opens the amazon app.

Device & build information

┆Issue is synchronized with this Jira Task

athomasmoz commented 4 years ago

There is a feature on iOS that allows us to open links directly into other apps if they exist on the device. We currently support this in both regular browsing and private browsing mode, so this is expected behaviour. However, I think it's worth considering if it's the right behaviour in private browsing mode. @AmyYLee tagging you to consider in our conversations about private browsing mode.

AmyYLee commented 4 years ago

@athomasmoz In Fenix we have a warning dialogue that pops up before launching the app to warn users that their activity will no longer be private. We could have a warning dialogue on iOS as well.

"Open in app? Your activity may no longer be private."

Link URL

Cancel Open

athomasmoz commented 4 years ago

Yea, I think that's a good approach. Allows users to choose if they prefer the app versus browser

AmyYLee commented 4 years ago

Private tab - Open in app warning

@betsymi to confirm copy. I copied the strings from Fenix.

athomasmoz commented 4 years ago

@AmyYLee is it possible to have the user choose between opening in the app and opening in PBM?