search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.09k stars 2.88k forks source link

HTML Injection on ReaderMode Page (needs to be in WKContentWorld) #6946

Open garvankeeley opened 4 years ago

garvankeeley commented 4 years ago

Moved from https://bugzilla.mozilla.org/show_bug.cgi?id=1633140

See the original bug for full repro steps. Because reader mode is in the JS context of the page, any JS build-in functions can be overriden to mess with the reader mode JS. This is a known limitation of JS injection with WKWebView, and is not considered a sec issue in this case.

The iOS 14 WKContentWorld should resolve this.

┆Issue is synchronized with this Jira Task

diracdeltas commented 2 years ago

@garvankeeley this is how Brave is proposing to fix this: https://github.com/brave/brave-ios/pull/4209/files

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale. Has the issue been fixed, or does it still require the community's attention? Please leave any comment to keep this issue opened. It will be closed automatically if no further update occurs in the next 30 days. Thank you for your contributions!