mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.22k stars 2.93k forks source link

Bug: Default browser tracking dropped in v30 #7807

Closed data-sync-user closed 2 years ago

data-sync-user commented 3 years ago

The numbers for app_opened_as_default_browser drastically dropped starting Dec 18th

See details in query: https://sql.telemetry.mozilla.org/queries/76731/source?p_Begin%20Date=2020-09-17&p_Counter=app_opened_as_default_browser&p_End%20Date=d_now#191282

┆Issue is synchronized with this Jira Task

data-sync-user commented 3 years ago

➤ Nishant Bhasin commented:

Preliminary investigation shows that this event gets fired at the right time.

Sample flow:

data-sync-user commented 3 years ago

➤ Nishant Bhasin commented:

After more investigation I think I figured out whats going on. In the original query the regex was incorrect and it wasn't including version 30.0 of our iOS Firefox app in the result and hence we got incorrect values from our query.

I have forked the original query and made changes so that it has proper regex and that will also include v30 of iOS Firefox App when it runs Set as Default Browser query. I have also added comments in the query as well.

Updated Query: https://sql.telemetry.mozilla.org/queries/77221/source?p_Begin%20Date=2020-12-01&p_Counter=app_opened_as_default_browser&p_End%20Date=d_now ( https://sql.telemetry.mozilla.org/queries/77221/source?p_Begin%20Date=2020-12-01&p_Counter=app_opened_as_default_browser&p_End%20Date=2021-01-07 )

[~athomas@mozilla.com] ^ this should give you proper results

Let me know if it works for you.

data-sync-user commented 3 years ago

➤ Ashley Thomas commented:

Thanks, Nish. I feel silly now for logging the ticket, but glad it was an easy fix!