search

mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.14k stars 2.9k forks source link

Crash if Siri tries to open a new tab from lock screen #8088

Open lukasbalaz opened 3 years ago

lukasbalaz commented 3 years ago

Steps to reproduce

  1. Set Firefox as the default browser
  2. Quit Firefox app (so it is not even running in the background)
  3. Lock the iPhone
  4. Open Siri from the lock screen and say “Google firefox” (or whatever else)
  5. Click the first link

Expected behavior

The Firefox app should open with a new tab

Actual behavior

The app opens and immediately crashes. After restoring the tabs after crash, the new tab is still not opened.

Device & build information

https://user-images.githubusercontent.com/13100133/110215691-5fff3400-7eab-11eb-83d5-73076c66f881.MP4

┆Issue is synchronized with this Jira Task

SimonBasca commented 3 years ago

I was able to reproduce the issue after restarting the device and following the STR on v32.0 (3841) on iPhone Xr (14.4). In my case the issue was not reproducible without restarting the device.

Note:

Crashlog

Client-2021-03-08-162117.ips.zip

z-aki commented 3 years ago

For me, having instagram.com open (no need to log in, just homepage) in private mode before quitting Firefox causes the crash. It happens only if the link you're clicking is one of many, instead of say, siri improved wikipedia article of Firefox.

SimonBasca commented 3 years ago

This issue is still reproducible on v34.0 (4900).

aevansWL commented 2 years ago

I have also had this issue any time I use Siri to search from the Lock Screen, even when all other apps are closed.

Device info: iPhone XR, iOS 15.1, FF v.39.0

data-sync-user commented 2 years ago

➤ Simion Basca commented:

Verified fix on main a9d1f4e090a7d0b62e1d89c588de87c35cc8ca66. Firefox no longer crashes when opening a tab via Siri Shortcuts.

junbio commented 2 years ago

I hate to be the bearer of bad news, but Firefox crashes for me on v98.1 when opening from Siri on the lock screen. The crash log says BrowserViewController.tab(_:didCreateWebView:) is responsible but checking over the changes since then I haven't found anything new that would have caused this crash to appear.

lmarceau commented 2 years ago

Let's reopen the issue then to keep discussion on this topic visible

esidegallery commented 1 year ago

This is still happening in Firefox 111.2