[XCUITests] Add variables for each accessibility ID

mozilla-mobile / firefox-ios

Firefox for iOS

Mozilla Public License 2.0

12.17k stars 2.92k forks source link

[XCUITests] Add variables for each accessibility ID #8301

Closed isabelrios closed 1 year ago

isabelrios commented 3 years ago

It will be a nice to have and a great improvement to have all the accessibility identifiers as variables in a separate file so that in case we need to change it, it will be only in one place.

See for example this part of one test: https://github.com/mozilla-mobile/firefox-ios/blob/main/XCUITests/TopTabsTest.swift#L123 there is an ID that is used several times in the same tests, in the test suite and also in the screengraph.

┆Issue is synchronized with this Jira Task

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale. Has the issue been fixed, or does it still require the community's attention? Please leave any comment to keep this issue opened. It will be closed automatically if no further update occurs in the next 30 days. Thank you for your contributions!

lmarceau commented 1 year ago

Since only data-sync-user has commented on the issue after the Stalebot GitHub action (which triggered the removal of the stale label) I’ll close this issue for now. Please let us know if you think this issue needs to be reopened, we'll gladly do so. Thank you!