mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.23k stars 2.94k forks source link

Setting homepage to empty page not possible in Firefox 37 #9124

Open kar8nga opened 3 years ago

kar8nga commented 3 years ago

I like Firefox a lot. I even use it on ios, although I miss my extensions for a silent and usable web.

The recent update to version 37 [release notes] changed the behaviour to suddenly show the homepage. I am not in favour of that (I like using my browser, not my browser telling me how to use it and showing showing information about my past browsing -- I have the history for that). If I can not avoid the homepage, then I want an empty page, as for a new tab.

Attempted solution: I can set the homepage to a custom one [homepage settings]. Wonderful, I thought, "about:blank" is my friend. Unfortunately, the UI does not let me.

Preferred workaround: The "New tab" setting allows 3 choices "Firefox Home", "Empty page" and "custom url". If you add the "Empty page" option to the homepage customisation menu, too, then this would work around the issue.

Preferred solution: Make the homepage popup at startup (or after several hours, as described in [release notes]) an option. This respects current behaviour and solves the problem.

release notes homepage settings

┆Issue is synchronized with this Jira Task

camall3n commented 3 years ago

I don't have the codebase downloaded, so I can't run the tests, but it seems like the fix is as simple as something like this: https://github.com/camall3n/firefox-ios/commit/5d06812cde2699cb2ac4060ef8d65f17d614f895

kar8nga commented 3 years ago

@camall3n: I do not know swift at all, but the logic seems to capture my intent well. Thanks for picking it up.

thomasmerz commented 3 years ago

This seems already being fixed in 38(.1) 🤷🏻‍♂️

5404EEFD-7F48-4998-AA9A-CED851BAED0E

When I start FF there's no "FF Home" showing, but my open tabs. Same for new tabs - no "FF Home" showing, but a blank page. Even with "FF Home" as homepage:

12A84E49-152A-4AA3-BC67-5293FD629E83

thomasmerz commented 3 years ago

Look at this: https://github.com/mozilla-mobile/firefox-ios/pull/9019 and https://github.com/mozilla-mobile/firefox-ios/pull/9238 👍🏻