Night Mode should disable on pages that have a dark mode

mozilla-mobile / firefox-ios

Firefox for iOS

Mozilla Public License 2.0

12.14k stars 2.91k forks source link

Night Mode should disable on pages that have a dark mode #9683

Open ghost opened 2 years ago

ghost commented 2 years ago

Go to GitHub.com with Night Mode on.

The site’s native dark mode should be displayed.

However, Firefox for iOS inverts colors, so the page is displayed all white.

You could have a look at Noir for Safari. This Night Mode addon for Safari on iOS and macOS detects sites with a dark mode and displays it instead of inverting colors. This approach would improve Firefox on iOS and iPadOS.

┆Issue is synchronized with this Jira Task

lmarceau commented 2 years ago

I'm not sure this is a feature-request, but more of a bug 🤔 @SimonBasca Night mode should be kept "night" and don't reverse the theme to put it light.

jrusinek commented 1 year ago

How about some inspiration from a functional extension? https://github.com/darkreader/darkreader

anna-yeddi commented 10 months ago

The issue can be reproduced when GitHub.com is set to its own Dark theme (not the light one). Then, turning on Night Mode in Firefox does invert colors as captured in the video attached.

Marking it as access-s3 https://github.com/mozilla-mobile/firefox-ios/assets/40773610/89061ab0-efc3-4d43-a3d1-4c764121cd9f