mozilla-mobile / firefox-ios

Firefox for iOS
Mozilla Public License 2.0
12.14k stars 2.91k forks source link

Logins & Passwords - cannot filter by password #9737

Open jscher2000 opened 2 years ago

jscher2000 commented 2 years ago

Steps to reproduce

In the Filter bar on the Logins & Passwords page, type the first character of a known password (this issue does not affect user names).

Expected behavior

Matching login should be displayed, similar to Firefox on desktop.

Actual behavior

Nothing is displayed. Ref. https://support.mozilla.org/questions/1363176

I cannot tell whether #9666 covers this because the problem doesn't seem to be caused by typing too quickly or failing to cancel a previous search.

Device & build information

┆Issue is synchronized with this Jira Task

SimonBasca commented 2 years ago

We currently don't support filtering logins by password search. This is a feature request rather than a bug or issue. We will discuss with the team and triage it accordingly. Thanks for the feedback.

SMe-eiSmart commented 2 years ago

Hi Simon, what's this filter option for if not for searching passwords? Searching for passwords worked pretty well in Lockwise.

robertburke14 commented 2 years ago

Yeah, what? This definitely worked in the past, the search bar is present in the current release, and the release notes explicitly mention this being fixed. It’s still not working for me. I get an endless spinner and the app crashes if I tap the ‘x’.

lmarceau commented 2 years ago

@robertburke14 There's three fields that are saved in the Logins & Passwords view: Website, Username and Password. The search bar filters the website and username fields. Passwords aren't searched.

In other words, if I have the following: Website: www.mywebsite.com Username: myname Password: 123456

If I go in the search bar and enter 123456 that entry isn't going to appear. The feature request here is that 123456 would find that entry.

robertburke14 commented 2 years ago

I see. I'm having trouble searching by website and username still.

lmarceau commented 2 years ago

@robertburke14 On which version are you? There was supposed to be a recent fix on that matter.

robertburke14 commented 2 years ago

I saw that, which is why I'm confused. I'm on the most recent - 97. Like I said, it just spins and spins and crashes if I try to cancel.

lmarceau commented 2 years ago

@SimonBasca Do you know more about this here ^^ ?

robertburke14 commented 2 years ago

@lmarceau thanks for looking into this!

SimonBasca commented 2 years ago

We had a similar issue that should have been fixed in v97.0 (#9477). Unfortunately I was unable to reproduce the issue before or after the fix. In my case the the login search filed was filtering correctly.

@robertburke14 on what device and iOS version is the issue reproducible? Do you have a large number of logins synced?

robertburke14 commented 2 years ago

I was on an iPhone 8 with the most recent versions of Firefox. I've updated to an iPhone 13, and while the logins do load now when searching, they all say "(no username)" and have no password. It no longer prompts to enter remembered passwords either. 23546155-4A43-4956-847A-3B56B3E0EB1F