Emulator only: loading URL goes through many non-primary sites, sticks in overlay

mozilla-mobile / firefox-tv

Firefox for Amazon's Fire TV

https://blog.mozilla.org/blog/2017/12/20/firefox-is-now-on-amazon-fire-tv-happy-holiday-watching/

Mozilla Public License 2.0

255 stars 109 forks source link

Emulator only: loading URL goes through many non-primary sites, sticks in overlay #1444

Open severinrudie opened 6 years ago

severinrudie commented 6 years ago

NOTE: reproducible on emulator only

Steps to reproduce

Turn on Turbo mode
Select RottenTomatoes tile

Expected behavior

Progress bar should display "www.rottentomatoes.com"

Actual behavior

Progress bar rapidly shifts between ad related URLs

Device information

Fire TV device: Emulator
Firefox version: f4d3262811011976ac913e66c08c7b160318e5e7

with-turbo

severinrudie commented 6 years ago

Won't fix: issue filed for documentation purposes only

mcomella commented 6 years ago

The URL that ends up in the overlay is not always the page that was loaded. STR:

Visit mozilla.org
Wait for page to load
Open overlay

Expected: url is mozilla.org Actual: url is google analytics. See screenshot: screenshot_1541120121

This is bad because it makes it difficult to know if our code is working correctly when running on the emulator.

Since we discovered this problem before, it's likely that this is a recent regression.

mcomella commented 6 years ago

@pocmo Has anything changed in a-c that might have caused this? If there's nothing on the top of your head, we'll investigate: it could be us too! :)

mcomella commented 6 years ago

Once this is fixed, we'll have to fix NetworkPageLoadTest (assuming #1448 lands).

pocmo commented 6 years ago

@pocmo Has anything changed in a-c that might have caused this? If there's nothing on the top of your head, we'll investigate: it could be us too! :)

I don't remember any change in that area that could have caused this. I only see us updating the URL in the Session from onPageStart() and onPageFinished().