search

mozilla-mobile / firefox-tv

Firefox for Amazon's Fire TV
https://blog.mozilla.org/blog/2017/12/20/firefox-is-now-on-amazon-fire-tv-happy-holiday-watching/
Mozilla Public License 2.0
257 stars 111 forks source link

Can't close YouTube search box using Bluetooth keyboard #1965

Open cpearce opened 5 years ago

cpearce commented 5 years ago

Steps to reproduce

  1. Attach a BlueTooth keyboard to your FireStick 4K. I'm using a Logitech K380.
  2. Open Firefox on FireStick 4K (I am using a version I built locally based on b8acc09d).
  3. Open YouTube.
  4. Press 'S' to open the YouTube's search box dialog.
  5. Press 'ESC'

Expected behavior

Search dialog should close.

In the Silk browser, pressing ESC causes the search dialog to close.

Actual behavior

Search dialog stays open.

I have observed this behaviour occurs with both the GeckoView and SystemView based Firefox browsers.

Another weirdity, when I open YouTube in the Firefox browser which I download from Amazon's app store, and press 'S', I don't get the same search box. So either we're getting a different YouTube served to the store Firefox browser, or it's behaving sufficiently differently that it doesn't open the search dialog.

Device information

athomasmoz commented 5 years ago

@cpearce Is there a workaround for this issue? Another keyboard button that can be used?

liuche commented 5 years ago

On the emulator using the cmd+backspace (or another key that triggers a "back") will work - is that something that could help?

cpearce commented 5 years ago

@liuche No combination of back alt/ctrl/shift/backspace/esc seems to dismiss the text entry dialog. I realised, it's not a YouTube dialog, it's the system text entry dialog.

cpearce commented 5 years ago

This is similar to issue#1844.

Interestingly, when I tested today using firefox-tv with system webview, on YouTube.com/tv when I press 'S' on the keyboard, we don't open the system text input dialog. Maybe the issue here is that the GV variant isn't preventing the text input dialog showing?

athomasmoz commented 5 years ago

Is this blocking you at all? It's outside our standard use cases, so I would mark this as a lower priority unless you need it.

cpearce commented 5 years ago

I'm not blocked per se, it is however very annoying, as it's basically impossible to twiddle prefs in about:config or to search on YouTube. When I accidentally open the keyboard dialog on about:config or YouTube's search pane, my only recourse is to kill the app via adb. Most users won't be able to do that.

cpeterso commented 5 years ago

@cpearce - Can you still reproduce this keyboard bug? Makoto landed a fix last week related to GV's handling of the Fire TV key codes that might be related.

https://bugzilla.mozilla.org/show_bug.cgi?id=1530486