search

mozilla-mobile / firefox-tv

Firefox for Amazon's Fire TV
https://blog.mozilla.org/blog/2017/12/20/firefox-is-now-on-amazon-fire-tv-happy-holiday-watching/
Mozilla Public License 2.0
257 stars 111 forks source link

Warning during compilation: "removing resource ...mocac... without required default value" #2677

Open mcomella opened 5 years ago

mcomella commented 5 years ago

Vision statement / What / Requirements

When compiling a local build (./gradlew assembleSystemDebug), I get the following warning:

warn: removing resource org.mozilla.tv.firefox.debug:string/mozac_feature_applinks_confirm_dialog_confirm without required default value.
warn: removing resource org.mozilla.tv.firefox.debug:string/mozac_feature_applinks_confirm_dialog_deny without required default value.
warn: removing resource org.mozilla.tv.firefox.debug:string/mozac_feature_applinks_confirm_dialog_title without required default value.
warn: removing resource org.mozilla.tv.firefox.debug:string/mozac_feature_applinks_open_in without required default value.

Impact

I don't know what the effect of this is but we don't use applinks so and it's just a warning about a string resource so I think minimal.

Acceptance criteria

@pocmo Have you seen this before? We don't explicitly include this string so I don't know what's happening.

pocmo commented 5 years ago

@pocmo Have you seen this before? We don't explicitly include this string so I don't know what's happening.

For the initial release of Fenix we had to add those strings to browser-errorspages to get them translated before the actual feature-applinks component could land.

@jonalmeida moved the strings later to the right component in https://github.com/mozilla-mobile/android-components/commit/591bc2bfd02c81812e027af22b3ca4b8dcff3273

But looking at the repo it looks like the translations are still around, for example here: https://github.com/mozilla-mobile/android-components/blob/master/components/browser/errorpages/src/main/res/values-es/strings.xml#L262-L269

@Pike Is this the intentional behavior of compare-locales? I would have expected it to remove those translated strings on the next import.

Pike commented 5 years ago

Files are only changed if the localization changes, so when there's nothing to do, or localizers fall behind, the obsolete strings just stay around.

That's because we're not converting, we're just copying the actual translation files around.

mcomella commented 5 years ago

@pocmo Should this issue be refiled as part of a-c then?