search

mozilla-mobile / firefox-tv

Firefox for Amazon's Fire TV
https://blog.mozilla.org/blog/2017/12/20/firefox-is-now-on-amazon-fire-tv-happy-holiday-watching/
Mozilla Public License 2.0
257 stars 111 forks source link

Enable Push/send tab to GitHub releases builds by adding api_key.txt #2870

Open mcomella opened 5 years ago

mcomella commented 5 years ago

Vision statement / What / Requirements

For builds uploaded to the Amazon store, Amazon inserts an API key to enable push, which enables features like send tab. However, we upload builds to GitHub releases that do not go through the Amazon store: these do not have push, and features like send tab, enabled.

Ideally, we'd insert our own api_key.txt so that these builds support Push and features like send tab.

Releng is currently changing our release automation, which could affect how this is implemented, so we may wish to wait until they are done before addressing this issue.

Impact

If this bug is not fixed, folks downloading builds from GitHub Releases will not have push enabled. This is important for QA & regression analysis but will also affect folks who like to sideload (note: push is currently only supported on Amazon platforms).

Acceptance criteria

mcomella commented 5 years ago

P3: because there is a workaround for developers trying to bisect: check out and build locally.