search

mozilla-mobile / firefox-tv

Firefox for Amazon's Fire TV
https://blog.mozilla.org/blog/2017/12/20/firefox-is-now-on-amazon-fire-tv-happy-holiday-watching/
Mozilla Public License 2.0
253 stars 108 forks source link

String translations/l10n import + export for v2.0 #523

Closed liuche closed 6 years ago

liuche commented 6 years ago

Here are the outstanding strings that we need for translation:

Strings should be exported and passed off to @Delphine by 3/6, and deadline for re-import is 3/12.

Delphine commented 6 years ago

Thanks! We've got our l10n repos up and Pontoon hooked up for translation. Jeff did an export last week, so we can follow the same process from now on for strings :) thanks!

liuche commented 6 years ago

@lime124 and @BrianNJones are there any other new strings that we need for 2.0? I think "delete" we can reuse.

lime124 commented 6 years ago

We don't have that many visible strings in general. For accessibility, I'm not sure where those strings are saved. Do you @liuche ? Ideally, I would like to just be able to look at the strings.xml file to give a better answer but right now there's too much extra stuff in there.

In the nav overlay there's:

In the browser there aren't any strings that come to mind outside of the error strings we reused from Focus.

On the homsecreen:

Settings, everything is the same. We do need to update some of them but haven't done it. And we aren't doing parental controls.

And finally Turbo Mode onboarding, we didn't touch that screen at all either.

Surely I've forgotten something, that seems like very few strings...?

liuche commented 6 years ago

Thanks for the follow-up, @lime124 ! Self-assigning to go through the strings Tif highlighted and get the strings in for exporting (and also go through any more of the mocks). @Delphine we'll plan to have an export to you on Tuesday 3/6 (at the latest).

liuche commented 6 years ago

@bbinto @Sdaswani what's the date for the last string import from l10n? 3/12 will give us 2 weekends for localization (but that's only one day before the release which is 3/13).

(3/9 was our original code freeze so I told Delphine that would be the earliest deadline for "last import".)

Sdaswani commented 6 years ago

I'm fine 3/12 being the last date for import, assuming all we do on 3/12 is import new strings into the 2.0 branch that we froze on 3/7.

Delphine commented 6 years ago

Thanks everyone! I think that should work. I've notified localizers about the next export date for strings as well as the deadline for completion.

boek commented 6 years ago

I added Close as well to the checklist

BrianNJones commented 6 years ago

Thanks Tif. I've been locked out of email since Friday (had to get new phone and multi-factor auth via DUO wasn't playing nice).

We've prioritized re-using strings, so new ones should be minimal. Nav overlay "Search or enter address" is in both Firefox and Focus. The 2 toast strings are net-new, however.

-Brian

On Fri, Feb 23, 2018 at 3:21 PM, Tiffanie Shakespeare < notifications@github.com> wrote:

We don't have that many visible strings in general. For accessibility, I'm not sure where those strings are saved. Do you @liuche https://github.com/liuche ? Ideally, I would like to just be able to look at the strings.xml file to give a better answer but right now there's too much extra stuff in there.

In the nav overlay there's:

  • Search or enter address [in the text box]
  • Close [isn't in the UI yet - @liuche https://github.com/liuche you filed a ticket for that]
  • the two strings above for the toast [pinned/removed from homescreen]

In the browser there aren't any strings that come to mind outside of the error strings we reused from Focus.

On the homsecreen:

  • Search or enter address [which is the one as from the nav overlay]
  • the tiles use URLs/page titles - things that don't need translation
  • the context menu, we'll only have "Remove"

Settings, everything is the same. We do need to update some of them but haven't done it. And we aren't doing parental controls.

And finally Turbo Mode onboarding, we didn't touch that screen at all either.

Surely I've forgotten something, that seems like very few strings...?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mozilla-mobile/firefox-tv/issues/523#issuecomment-368141921, or mute the thread https://github.com/notifications/unsubscribe-auth/Ad38ly89S5DMzswgFm2TOaDI3TjQKCSXks5tXyvFgaJpZM4SRXoQ .

Delphine commented 6 years ago

@liuche: hey, any updates concerning the string export for this? will you be doing any in the end? thanks!

liuche commented 6 years ago

Hi @Delphine, I'm just wrapping up the last new string I think we'll have, #551. I could do an export earlier than March 6 (discussed earlier in the thread), like later today or tomorrow - will ping you about that.

Delphine commented 6 years ago

@liuche: Aha, ok I got confused - I understood we were supposed to get these strings last Tues (but the thread indicates I'm wrong, haha!). Thanks!

liuche commented 6 years ago

Closing this because everything is done - we'll do one more string import on 3/12.

Delphine commented 6 years ago

@liuche: Unless I'm missing something - since we just exposed strings a couple hours ago, I think we're going to need a couple (few? Depending on if we need to go in and fix strings - to check they are in fact fixed) more imports before 3/12 in order to generate up to date screenshots for l10n QA. I can let you know when locales are looking more caught up.

Sdaswani commented 6 years ago

I think that makes sense @Delphine - @npark-mozilla and @AaronMT have kindly volunteered to run screenshots as necessary, do let us know when they are caught up.

Delphine commented 6 years ago

@Sdaswani : Thanks! I see they are mostly caught up (all except 2 that are at 97%) If it's possible to run screenshots with latest strings today or tomorrow, that would be great. And then one last time at the very end of the week (since deadline I believe would be Mon). Thanks everyone!

Sdaswani commented 6 years ago

We will run them Thursday morning and next Monday evening - does that work @liuche ?