mozilla-mobile / firefox-tv

Firefox for Amazon's Fire TV
https://blog.mozilla.org/blog/2017/12/20/firefox-is-now-on-amazon-fire-tv-happy-holiday-watching/
Mozilla Public License 2.0
253 stars 108 forks source link

Fix the ripple effect on Fire TV diamond and the colors on the views it affects #648

Open mcomella opened 6 years ago

mcomella commented 6 years ago

By all buttons, I mean the overlay and settings on the homescreen. Two problems:

mcomella commented 6 years ago

I noticed removed the <item id="mask"> thing and it's children will let the ripple work on the diamond (but then it's unconstrained).

mcomella commented 6 years ago

I also tried the simple formats from https://developer.android.com/reference/android/graphics/drawable/RippleDrawable.html like:

<!-- A green ripple drawn atop a black rectangle. --/>
 <ripple android:color="#ff00ff00">
   <item android:drawable="@android:color/black" />
 </ripple>

And it works on the emulator but not on device.

Two thoughts:

mcomella commented 6 years ago

Can we reproduce this with API 25 (or whatever the diamond is) emulators? I'm running an API 22 emulator, like the Stick.

mcomella commented 6 years ago

We should also make sure the behavior we're seeing is consistent in a new app (i.e. ripple works on stick but not on diamond so our styles aren't screwing this up).

mcomella commented 6 years ago

I'm also opting to remove the ripple in settings: see #641 and the opened PR.