Open mcomella opened 6 years ago
I noticed removed the <item id="mask">
thing and it's children will let the ripple work on the diamond (but then it's unconstrained).
I also tried the simple formats from https://developer.android.com/reference/android/graphics/drawable/RippleDrawable.html like:
<!-- A green ripple drawn atop a black rectangle. --/>
<ripple android:color="#ff00ff00">
<item android:drawable="@android:color/black" />
</ripple>
And it works on the emulator but not on device.
Two thoughts:
Can we reproduce this with API 25 (or whatever the diamond is) emulators? I'm running an API 22 emulator, like the Stick.
We should also make sure the behavior we're seeing is consistent in a new app (i.e. ripple works on stick but not on diamond so our styles aren't screwing this up).
I'm also opting to remove the ripple in settings: see #641 and the opened PR.
By all buttons, I mean the overlay and settings on the homescreen. Two problems: