mozilla-mobile / focus-android

⚠️ Firefox Focus (Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android
https://github.com/mozilla-mobile/firefox-android
Mozilla Public License 2.0
2.11k stars 711 forks source link

Remove dependency on com.google.android.gms:play-services-analytics #1174

Closed st3fan closed 2 years ago

st3fan commented 7 years ago

It unclear why this (closed source proprietary) library is in the Focus APK. Focus does not not google analytics and neither does Adjust. If it is save to remove this because nobody is calling the code then that is probably a good idea.

pocmo commented 7 years ago

It's in there because of Adjust: https://github.com/adjust/android_sdk#sdk-gps

Since the 1st of August of 2014, apps in the Google Play Store must use the Google Advertising ID to uniquely identify devices. To allow the adjust SDK to use the Google Advertising ID, you must integrate the Google Play Services. If you haven't done this yet, follow these steps: [..]

bbinto commented 7 years ago

I'll flag this with Mike Han to see if Adjust can provide another solution

pocmo commented 7 years ago

I'll move this into the "blocked" column so that we can revisit this.

eldk commented 7 years ago

Hello,

https://www.mozilla.org/en-US/foundation/licensing/

Some opensource solutions are available : https://github.com/piwik/piwik-sdk-android ...

I think it's important for Focus. Klar has not embedded play services stuff.

Thanks,

Eric

pocmo commented 7 years ago

https://github.com/adjust/android_sdk/issues/297

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.