mozilla-mobile / focus-android

⚠️ Firefox Focus (Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android
https://github.com/mozilla-mobile/firefox-android
Mozilla Public License 2.0
2.11k stars 711 forks source link

Custom Tabs: Consider showing page title in URL bar. #2298

Closed pocmo closed 3 years ago

pocmo commented 6 years ago

User Benefit / Why

From #610 and #1870.

Chrome and Firefox show the page title in the URL bar in a Custom Tab. Do we want to do that too?

pocmo commented 6 years ago

Firefox:

ct-ff

pocmo commented 6 years ago

Chrome:

ct-chrome

pocmo commented 6 years ago

The app might be able to control this by setting NO_TITLE, SHOW_PAGE_TITLE;

shikhart98 commented 6 years ago

Can I work on this issue?

pocmo commented 6 years ago

@shikhart98 This will need input from the UX team and prioritization from the product team first. We try to mark everything that is ready to be worked on with "help wanted": https://github.com/mozilla-mobile/focus-android/labels/help%20wanted

shikhart98 commented 6 years ago

Okay 👍

bbinto commented 6 years ago

@brampitoyo quick input on the UI @pocmo suggested?

@pocmo is this touching the regular URL/address bar code for Focus?

brampitoyo commented 6 years ago

For sure. It makes a lot of sense for us to be consistent with Firefox and show the site name and URL on our custom tabs.

I do notice that the “X” button on the Firefox UI is far too large, and the font size is a bit too small. Chrome’s icon and font sizes are good for us to follow. It’s just that the font colour that Chrome uses isn’t consistent with the font colour used on the system status bar. On this, we should aim to match.

pocmo commented 6 years ago

@pocmo is this touching the regular URL/address bar code for Focus?

Yes, we would need to support two modes. If this doesn't have high priority then we could wait until our "toolbar" component is ready and use that one in Focus. The toolbar component will be able to support different modes like that.

bbinto commented 6 years ago

ETA, @pocmo, on the toolbar component? :)

pocmo commented 6 years ago

@bbinto Depends on the fenix feature prioritization.. :) I think it will take some time until the component has feature-parity with Focus. So, maybe in Q3 we can make the switch to the component.

Sdaswani commented 6 years ago

@pocmo @csadilek can one of the Focus engineers start on this component? We are keen to get this into Focus.

csadilek commented 6 years ago

@Sdaswani definitely! This would require bringing the toolbar component to Focus which would be great, imo.

Sdaswani commented 6 years ago

@vesta0 I suggest someone on the Focus team work on this in this Sprint - is that cool? Maybe @ekager's first component?

vesta0 commented 6 years ago

@Sdaswani that would be good. Sounds like the toolbar component is ready and can be brought over to Focus - is that correct? If so then @ekager do you want to pick this up?

Sdaswani commented 6 years ago

No @vesta0 sounds like we have to 1) integrate the toolbar component and then 2) maybe make some changes. I think @ekager can pick this up if she is free.

ekager commented 6 years ago

I can pick this up after my current ticket in this sprint

lobontiumira commented 3 years ago

On the latest RC 93.1.1, the custom tab displays the page title in the URL bar. I'll close this issue.