mozilla-mobile / focus-android

⚠️ Firefox Focus (Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android
https://github.com/mozilla-mobile/firefox-android
Mozilla Public License 2.0
2.11k stars 710 forks source link

Disable telemetry for "distributions" by default #2741

Closed pocmo closed 2 years ago

pocmo commented 6 years ago

Firefox for Android has a complex way to be customized by partners via Distribution files: https://wiki.mozilla.org/Mobile/Distribution_Files

Eventually we may want to have something similar in Focus. But we want to do some things differently this time. And for now we only need a way to control whether telemetry is enabled by default.

in Firefox for Android distributions can be: Baked into the APK, downloaded after installation (google play referrer) or loaded from a system path. All those have different advantages/disadvantages.

What we want to do with Focus is: The device manufacturer sets a specific read-only system property in the system image from which we can read the distribution id. At a later time we will use this ID to download a distribution file. For now we are just using the existence of the property as an indicator that we are running on a partner device.

The name of the property will depend on the package name:

ro.<package name>.distribution.id

ro.org.mozilla.focus.distribution.id
ro.org.mozilla.klar.distribution.id

For now: Whenever this property exists we disable telemetry by default (Not overriding the user choice though). At a later time we will download the matching distribution which will contain customizations options like disabling telemetry.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.