search

mozilla-mobile / focus-android

⚠️ Firefox Focus (Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android
https://github.com/mozilla-mobile/firefox-android
Mozilla Public License 2.0
2.11k stars 710 forks source link

8.0.25 requesting the READ_PHONE_STATE permission #4456

Closed STPR closed 2 years ago

STPR commented 4 years ago

8.0.25 requesting the READ_PHONE_STATE permission :

READ_PHONE_STATE Allows read only access to phone state, including the phone number of the device, current cellular network information, the status of any ongoing calls, and a list of any PhoneAccounts registered on the device.

colintheshots commented 4 years ago

It appears upgrading Google's Install Referrer library to the latest caused this. I believe we can safely downgrade in the next release.

STPR commented 4 years ago

Why can't you just keep the latest version and add the following line into the manifest ? <uses-permission android:name="android.permission.READ_PHONE_STATE" tools:node="remove" />

STPR commented 4 years ago

Strangely, Firefox Klar 8.0.25, the "german" version of Firefox Focus, doesn't need this permission !

Quite frankly, I really doubt you're discovering this just now. So, either you need it for some obscure reasons, or you should correct this immediatly. That's a MAJOR issue for a browser promoting itself as a "privacy browser".

Looking at all the comments inside the play store, you really should not wait the next release to correct this.

STPR commented 4 years ago

We are now at the 8.0.26 version and the permission is still there. So, what do you believe now ? Why is it so hard to put the following line in the manifest ? <uses-permission android:name="android.permission.READ_PHONE_STATE" tools:node="remove" />

STPR commented 4 years ago

We are now at the 8.1.0 version and the permission is still there. Do you still believe something ?

STPR commented 4 years ago

You don't have to believe something anymore. Just update the Google's Install Referrer library to version 1.1.2. (since you didn't want to use the previous fix in the manifest file)

lobontiumira commented 2 years ago

Verified as fixed on the latest Focus Nightly build 100.0a1 from 3/14 with Samsung Galaxy Note 8 (Android 9), and Lenovo Tab M10 (Android 10).