search

mozilla-mobile / focus-android

⚠️ Firefox Focus (Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android
https://github.com/mozilla-mobile/firefox-android
Mozilla Public License 2.0
2.11k stars 711 forks source link

Firefox Klar logo has wrong colors #5180

Closed cadeyrn closed 3 years ago

cadeyrn commented 3 years ago

Steps to reproduce

  1. compile Focus from the main branch with Klar branding

Expected behavior

The logo has the same colors as with the Focus branding.

Actual behavior

Wrong colored Firefox logo. A purple foreground on purple background does, obviously, not work very well.

The Klar logo is also noticeable larger than the Focus logo which seems wrong to me.

klar-logo

Device information

ionutbedregeanu commented 3 years ago

Because both logos suffered some changes I will update Focus logo as well in this ticket

Focus logo resource: https://drive.google.com/drive/folders/1ZUwG06Bq4YrTGHQal18sdsJrlYCbUz-r Klar logo resource: https://drive.google.com/drive/folders/1-Kb3ejWKjw1GTmPEiDXGr_Mfuys1CDu4

cadeyrn commented 3 years ago

QAReady

Whatever was changed with the latest PR it didn't fix the reported issues: The logo is still purple on a purple background and the logo of Firefox Klar is still noticeable larger than the logo of Firefox Focus: The fox logo is larger as well as the font size of the wordmark:

Bildschirmfoto 2021-08-25 um 11 39 55

I don't think that the flavour (Focus/Klar) should change the specs of the logo like font and fox size…

ionutbedregeanu commented 3 years ago

@cadeyrn Thank you! You are right, is a minor difference in size

@brampitoyo From what I see Focus logo has 384 width and 80 height while the Klar logo has 338 width and 80 height Can you help me with another resource in order to have the same dimensions for both? Not sure which are the intended ones?

mcarare commented 3 years ago

@cadeyrn These are the color from the design team, not sure what ales are to do about it, except for them reconsidering.

brampitoyo commented 3 years ago

@mcarare @ionutbedregeanu Sorry. I didn’t realise that the branding was implemented with a width that scales to the device. No wonder Firefox Klar appears taller!

I will re-export the Klar asset, so it has the same width as the Focus one. Then it should stop causing problem.

Focus Klar
ic_logo_wordmark_dark_horizontal-xxxhdpi ic_logo_wordmark_dark_horizontal_klar-xxxhdpi

Edit: I’ve done this, and have sent the link to you.

lobontiumira commented 3 years ago

Verified as fixed on the latest debug build from main from 8/30, with Lenovo Tab M10 (Android 10)

Untitled