Closed AndiAJ closed 2 years ago
Might be fixed with https://github.com/mozilla-mobile/focus-android/pull/5798. We'll wait for a while to see if it appears again and close this if not.
Not that fixes the problem, but I wonder why so many tests have this step (clearing browsing data) when they test other components of the app. If a test part makes a test flaky it should be avoided in places it is not necessary.
It is necessary. In the case of ETP tests, we need to load a page before the ETP test page to allow GV to load on a first cold startup (a thing I learned from Arturo :) ). If I don't clear the page, sometimes the app shows the content of the initial page instead of the ETP page. If I'd just refresh the ETP page it would show a blank page sometimes or hang. So by not clearing data, I would trade one flaky part of the test with another.
It is necessary. In the case of ETP tests, we need to load a page before the ETP test page to allow GV to load on a first cold startup (a thing I learned from Arturo :) ). If I don't clear the page, sometimes the app shows the content of the initial page instead of the ETP page. If I'd just refresh the ETP page it would show a blank page sometimes or hang. So by not clearing data, I would trade one flaky part of the test with another.
But you could get the same effect by pressing the back button (mDevice.pressBack()
) instead of the erase button. Am I wrong?
No, you are right, I could try that as well. Thanks for the tip.
Firebase Test Run: Firebase link
Stacktrace:
Build: 11/14 Main
Notes
❗ The last performed action was to tap the clearBrowsingData button after a tracker blocking page is properly opened.