mozilla-mobile / focus-android

⚠️ Firefox Focus (Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android
https://github.com/mozilla-mobile/firefox-android
Mozilla Public License 2.0
2.11k stars 711 forks source link

For #7887 fix flaky verifyDownloadedFileOnStorageTest UI test #7998

Closed AndiAJ closed 1 year ago

AndiAJ commented 1 year ago

For #7887 fix flaky verifyDownloadedFileOnStorageTest UI test ✅ successfully passed 100x. on Firebase

Summary: For verifying that the downloaded file is actually saved on the device, we used similar code with what we have in AC to handle downloads.

Rarely, the test was flaky, failing to verify that the file is actually saved on the device storage (not sure why the returned download uri was null)

As an alternative, @Mugurell suggested to try using the implementation from this tutorial

I made the changes based on our interest, and it seems to be working properly.

Pull Request checklist

QA

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to build-focus-debug or build-klar-debug for changes targeting Klar,
  3. click View task in Taskcluster,
  4. click the Artifacts row,
  5. click to download any of the apks listed here which use an appropriate name for each CPU architecture.

GitHub Automation

Fixes #7887

AndiAJ commented 1 year ago

Adding @Mugurell as a reviewer, to share his thoughts as well. 🤞🏽

AndiAJ commented 1 year ago

Thanks @Mugurell , made the changes as suggested.