Bug 1802664 - Hide fragment content when app is locked.

mcarare commented 1 year ago

Pull Request checklist

[x] Tests: This PR includes thorough tests or an explanation of why it does not
[x] Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
[x] Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

[x] QA Needed

To download an APK when reviewing a PR:

click on Show All Checks,
click Details next to build-focus-debug or build-klar-debug for changes targeting Klar,
click View task in Taskcluster,
click the Artifacts row,
click to download any of the apks listed here which use an appropriate name for each CPU architecture.

GitHub Automation

Used by GitHub Actions.

mcarare commented 1 year ago

This is now ready for review. It includes handling the custom tabs and switching between private tabs and custom tabs properly. Manual testing is also appreciated, in case other flows still need attention and to ensure it works on other devices ( I tested it on 3 devices - Android 9, 10, 13).

gabrielluong commented 1 year ago

Hey @mcarare, we're tidying the opened PRs in this repo since this project moved to a new repository. It is now developed and maintained at: https://github.com/mozilla-mobile/firefox-android. Please reopen a new PR there if the issue is still relevant. Thank you!

mozilla-mobile / focus-android