Invalid Char While Entering Text in AutocompleteTextField with Previous Text

mozilla-mobile / focus-ios

⚠️ Firefox Focus (iOS) has moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-ios

Mozilla Public License 2.0

1.26k stars 262 forks source link

Invalid Char While Entering Text in AutocompleteTextField with Previous Text #1264

Closed marchiore closed 6 years ago

marchiore commented 6 years ago

error-focus

Steps to reproduce:

Run Focus on v7.0-dev
Type Tand press Enter
Type M

marchiore commented 6 years ago

ping @oliviabrown9

oliviabrown9 commented 6 years ago

Good catch - it's an interesting issue. It looks to me like it's A. always reproducible. and B. always whatever the last character of the previous URL was.

oliviabrown9 commented 6 years ago

It's directly related to this change: https://github.com/mozilla-mobile/focus-ios/pull/1248#discussion_r210928522

CC: @sblatz

sblatz commented 6 years ago

This appears to actually be a bug with AutocompleteTextField. I've submitted a patch to keep 6.0 functionality with the end of the URLText showing until it can be fixed.

oliviabrown9 commented 6 years ago

Closed with https://github.com/mozilla-mobile/focus-ios/pull/1273