mozilla-mobile / focus-ios

⚠️ Firefox Focus (iOS) has moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-ios
Mozilla Public License 2.0
1.26k stars 263 forks source link

Search engine telemetry is wrong #1715

Closed rugk closed 1 year ago

rugk commented 4 years ago

I use Firefox Klar (the German version) on an iOS 13.4.1 device. (Klar seems to be v8.1.4)

If you manually enable telemetry, it seems to send some data at start (or shutdown?).

However, there is always an error. So when I change my search engine to DuckDuckGo, or in this test Twitter, let's see what happens…

https://incoming.telemetry.mozilla.org/submit/telemetry/9ED1C790-[…]/core/Klar/8.1.4/[…] gets this data, which is correct:

{
    "arch": "arm64",
    "clientId": "2A[…]",
    "created": "2020-07-27",
    "defaultSearch": "Twitter",
    "device": "iPhone8,1",
    "durations": 12,
    "locale": "de-DE",
    "os": "iOS",
    "osversion": "13.4.1",
    "profileDate": 18470,
    "searches": {},
    "seq": 19,
    "sessions": 1,
    "tz": -420,
    "v": 7
}

However, https://incoming.telemetry.mozilla.org/submit/telemetry/F8AC070[…]/focus-event/Klar/8.1.4/[…] gets this:

{
    "arch": "arm64",
    "clientId": "2A[…]",
    "created": 1595885464421,
    "device": "iPhone8,1",
    "events": [
        [
            1204844,
            "action",
            "background",
            "app",
            null,
            {
                "orientation": "Landscape"
            }
        ],
        [
            1268740,
            "action",
            "foreground",
            "app"
        ],
        [
            1269878,
            "action",
            "click",
            "settings_button"
        ]
    ],
    "locale": "de-DE",
    "os": "iOS",
    "osversion": "13.4.1",
    "processStartTimestamp": 1595884163692,
    "seq": 11,
    "settings": {
        "BiometricLogin": "false",
        "BlockAds": "true",
        "BlockAnalytics": "true",
        "BlockFonts": "false",
        "BlockOther": "true",
        "BlockSocial": "false",
        "enableSearchSuggestions": "true",
        "prefKeyEngine": "Google"
    },
    "tz": -420,
    "v": 1
}

What should happen

Notice it sends Google for prefKeyEngine, while I actually do not use Google. Any other setting (I've tried toggling BlockSocial and BlockOther) seems to be correctly reflected there.

┆Issue is synchronized with this Jira Task

razvanlitianu commented 1 year ago

@rugk is this issue still applicable? cc: @Dexterp37

Dexterp37 commented 1 year ago

@razvanlitianu this is legacy telemetry, which is not maintained and is going to be deprecated next year.

razvanlitianu commented 1 year ago

Okay, closing this for now.