search

mozilla-mobile / focus-ios

⚠️ Firefox Focus (iOS) has moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-ios
Mozilla Public License 2.0
1.26k stars 262 forks source link

Delivery Issues - Invalid Siri Support #2119

Closed st3fan closed 1 year ago

st3fan commented 3 years ago

We are getting the following email on every app we push to AppStoreConnect. This doesn't seem to be blocking since we have been shipping many releases with these issues unfixed. But we should obviously get this in order.

The reason for this is simple: the Siri support that was added to Focus was never properly localized. I've intentionally not included the Blockzilla/en.lproj/Intents.strings in the recent export because I have no idea yet how those strings are used and how we give them proper keys.

The issue to export the Intent.strings is https://github.com/mozilla-mobile/focus-ios/issues/2118

Dear Developer,

We identified one or more issues with a recent delivery for your app, "Firefox Klar" 36.0 (5767). Your delivery was successful, but you may wish to correct the following issues in your next delivery:

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: hsb

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: af

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: ka

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: uz

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: cs

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: sk

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: es-es

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: ru

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: pt-pt

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: fa

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: es-es

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: hu

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: pl

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: ta

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: pt-pt

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: bs

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: gu-in

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: vi

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: kab

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: id

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: ko

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: gu-in

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: hy-am

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: ar

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: fil

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: es-mx

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: mr

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: ta

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: ga

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: sk

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: ms

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: fa

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: cs

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: hsb

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: it

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: my

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: th

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: bg

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: kab

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: nb

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: bn

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: fr

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: fil

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: tr

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: ia

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: ses

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: es-ar

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: pt-br

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: zh-cn

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: zh-tw

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: es-ar

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: it

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: af

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: cy

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: zh-tw

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: ne-np

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: fi

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: tr

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: ca

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: kk

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: ja

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: te

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: ses

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: hy-am

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: an

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: es-cl

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: hu

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: br

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: sv

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: ka

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: da

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: lo

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: eo

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: eu

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: ar

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: ro

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: id

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: he

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: ko

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: br

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: dsb

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: nl

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: cy

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: hi-in

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: kn

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: da

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: ur

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: gd

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: ast

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: uk

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: sq

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: ro

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: el

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: az

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: sl

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: is

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: bn

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: fr

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: nn

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: my

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: an

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: ur

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: bg

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: de

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: ia

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: es-cl

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: mr

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: kk

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: ast

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: ga

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: hi-in

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: sq

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: sl

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: dsb

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: fi

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: el

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: eu

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: nb

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: is

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: he

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: vi

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: zh-cn

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: ms

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: de

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: pl

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: kn

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: ru

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: pt-br

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: uz

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: nl

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: ne-np

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: gd

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: sv

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: th

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: lo

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: eo

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: te

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: nn

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: uk

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: ja

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: es-mx

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: ca

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: az

ITMS-90626: Invalid Siri Support - Localized title for custom intent: 'Erase' not found for locale: bs

After you’ve corrected the issues, you can upload a new binary to App Store Connect.

Best regards,

The App Store Team

┆Issue is synchronized with this Jira Task

st3fan commented 3 years ago

Good news! In the latest builds we still get these warnings, but only for those locales that have not localized this string yet. So I am confident that means we did the right thing with string export.

rtestard commented 1 year ago

This got resolved with https://github.com/mozilla-mobile/focus-ios/issues/3466