mozilla-mobile / focus-ios

⚠️ Firefox Focus (iOS) has moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-ios
Mozilla Public License 2.0
1.26k stars 263 forks source link

Share extension omits 'Firefox' #302

Closed AaronMT closed 7 years ago

AaronMT commented 7 years ago

screen shot 2017-08-16 at 10 03 40 am

We should abide by guidelines and use our full application name.

boek commented 7 years ago

@AaronMT good catch!

Sdaswani commented 7 years ago

Yes good catch but won't block Burgundy as we can't get the strings in. This needs immediate triage though if we want to get it in Cobalt. @antlam what's best next steps?

antlam commented 7 years ago

If there's space, we should include Firefox.

Open in Firefox Focus works I think.

CC @mheubusch for sign off!

mheubusch commented 7 years ago

Yes, agree to use Firefox Focus. (Think we cut out Firefox to save space, not for any communication reason).

antlam commented 7 years ago

Quick question before string freeze tomorrow because clearly this is the best time for this 😅 ... but would it be better to name the app Focus? everything in the UI can remain the same

Things to consider:

Just wanted to put that out there because I can't remember why we added Firefox at this moment.

@bbinto for input please! :)

bbinto commented 7 years ago

I believe this is mostly a branding/marketing question.

One thing we all agree on is to be consistent within the OS. In addition, we use "Firefox Focus" as well for Android.

So let's stick to "Firefox Focus".

Sdaswani commented 7 years ago

@bbinto, by 'stick to', you mean change to 'Open in Firefox Focus'? Shouldn't we check how the text fits in the Share Extension first?

bbinto commented 7 years ago

Yes, change it to Open in Firefox Focus, we def. should check first how it looks.

Also, do other apps shorten their app names as well in the share extension menu?

boek commented 7 years ago

Do we have any examples of a language that takes more characters than 'Open in'? I'm not sure about other apps. I think the default behavior truncates the string at a certain point.

boek commented 7 years ago

It also shrinks the text size:

image
boek commented 7 years ago

Here is 'Open in Firefox Focus' as well

image
Sdaswani commented 7 years ago

@boek can you try several form factors, e.g., iphone 5?

AaronMT commented 7 years ago

Is the adjective even necessary? I know exactly what to expect when I see or tap 'Twitter' and 'Facebook' in these cases. Focus, in it's current form has narrowly scoped utility. Why not just have 'Firefox Focus' and drop 'Open in'.

boek commented 7 years ago

iPhone 5:

image

I don't know if it will build for the iPhone 4

Sdaswani commented 7 years ago

Hah no need for the iPhone 4 :).

antlam commented 7 years ago

Is the adjective even necessary?

Good point. System conventions just use the app name if it's up there.

"Open in" was what we wanted to use when we wanted to make this an action I believe. @lime124 @mheubusch thoughts?

lime124 commented 7 years ago

Yes, "Open in" should be used when the app is in the Action area. If the app is in the Sharing Extensions area, only the app name is necessary.

Basically - either remove "Open in" OR put the it in the Action area. My preference would be to move it to the Action area.

Sdaswani commented 7 years ago

@boek I wonder if for 3.5 it should be just 'Firefox Focus' then? @lime124 we had it in the action menu but an iPad display issue that seemingly can't be fixed made us move it.

boek commented 7 years ago

@Sdaswani Sounds good to me

Sdaswani commented 7 years ago

@lime124 @antlam @boek has a PR to change the Share extension to say 'Firefox Focus' (and 'Firefox Klar') https://github.com/mozilla-mobile/focus-ios/pull/315/files - we don't need any localizations here, right? In all languages, we just use Firefox Focus - right?

boek commented 7 years ago

@Sdaswani @antlam This no longer needs strings as we are just using the product name correct?

antlam commented 7 years ago

@boek yep. Basically what @lime124 mentioned too - since it sounds like we're leaving this in the Share extension.

Sdaswani commented 7 years ago

@boek this should be closed to - it got into Burgundy, right?

boek commented 7 years ago

Yes