search

mozilla-mobile / focus-ios

⚠️ Firefox Focus (iOS) has moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-ios
Mozilla Public License 2.0
1.26k stars 263 forks source link

Unit test testListAdUrlsDuckDuckGo fails on Bitrise stack osx-xcode-14.1.x-ventura #3693

Open clarmso opened 1 year ago

clarmso commented 1 year ago

Steps to reproduce

On bitrise.yml, upgrade the stack from osx-xcode-14.0.x to osx-xcode-14.1.x-ventura. Run the workflow [unit_test_focus](https://app.bitrise.io/build/7abf4349-67c5-4d30-b43a-9659209708ba) on Bitrise.

Expected behavior

All unit tests pass on Bitrise.

Actual behavior

ClientTests/trackingAdsTests/testListAdUrlsDuckDuckGo() fails with the following error message on Bitrise:

/Users/vagrant/git/ClientTests/SearchEngineTests.swift:72 - XCTAssertThrowsError failed: did not throw an error

https://addons-testing.bitrise.io/builds/7abf4349-67c5-4d30-b43a-9659209708ba/testreport/bebd0425-4749-4008-ba76-a1b1c6a978bf/testsuite/0/testcases?status=failed

🤷🏼 I can't reproduce the failure on my machine locally....yet.

Device & build information

┆Issue is synchronized with this Jira Task

clarmso commented 1 year ago

Let me disable the test so that I can go ahead and upgrade the stack:

https://github.com/mozilla-mobile/focus-ios/pull/3689

isabelrios commented 1 year ago

We need to upgrade the stacks since the current one is going to be deprecated on Bitrise. That should not affect the unit tests... worth investigating what could be the cause.

CC developers as owners of the Unit Tests: @razvanlitianu @PARAIPAN9