search

mozilla-mobile / focus-ios

⚠️ Firefox Focus (iOS) has moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-ios
Mozilla Public License 2.0
1.26k stars 263 forks source link

Focus/Klar Appstore connect Errors (Localized description for custom intent) #3713

Open dsmithpadilla opened 1 year ago

dsmithpadilla commented 1 year ago

Around the time https://github.com/mozilla-mobile/focus-ios/pull/3706 was introduced we started receiving ios errors again from App Store connect

For example: We identified one or more issues with a recent delivery for your app, "Firefox Focus: Privacy browser" 9000 (16823). Your delivery was successful, but you may wish to correct the following issues in your next delivery:

ITMS-90626: Invalid Siri Support - Localized description for custom intent: 'Erase' not found for locale: hi-in

┆Issue is synchronized with this Jira Task

dsmithpadilla commented 1 year ago

Screenshot 2023-03-22 at 11 04 02 AM

dsmithpadilla commented 1 year ago

@razvanlitianu this is similar to https://github.com/mozilla-mobile/focus-ios/issues/3466 but this one started occurring on the 19th of March

dsmithpadilla commented 1 year ago

@razvanlitianu this was working for a while until another string import https://github.com/mozilla-mobile/focus-ios/commit/e2938e405121effeb7bbce317de85245c3a70f43 undid what https://github.com/mozilla-mobile/focus-ios/commit/081a572c5ac63c81ef2bb67d07b977c8d1b98ba0 fixed

dsmithpadilla commented 1 year ago

@razvanlitianu any update on this by any chance?