search

mozilla-mobile / focus-ios

⚠️ Firefox Focus (iOS) has moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-ios
Mozilla Public License 2.0
1.26k stars 263 forks source link

`carthage boostrap` reports "The dependency graph contained a cycle" #581

Closed mcomella closed 7 years ago

mcomella commented 7 years ago

I pulled master and upgraded to the latest carthage. carthage build & carthage bootstrap both reported this error:

The dependency graph contained a cycle:
GCDWebServer:
sentry-cocoa:
SnapKit:
telemetry-ios: OHHTTPStubs
ios_sdk:
Fuzi:
AutocompleteTextField:

master is 01dac80, which reverts to an older telemetry library. I checked out a previous revision, 083d98a, which is before the telemetry library was added and reverted, and it works correctly. I think there's a problem with the backout (perhaps Cartfile.resolved was not updated correctly?).

Looking at the commits:

@Sdaswani - why did you set this to a hash rather than a version code?

Sdaswani commented 7 years ago

@mcomella because we were using hashes earlier. agree it's not good. anyhow master needs to go back to 1.0.4.

Sdaswani commented 7 years ago

@garvankeeley said: "we had this and moved the Cartfile to be called tests-only-Cartfile: https://github.com/mozilla-mobile/telemetry-ios/blob/master/tests-only-Cartfile"

garvankeeley commented 7 years ago

Reverting to a known good version is the right idea for now. That should be an ignorable carthage warning, except for Firefox iOS BuddyBuild treats it as an error and stops the build. For that reason only we removed the Cartfile.

Sdaswani commented 7 years ago

3.9er is using a known good version, we will let 1.0.4 bake in master for the next release.