Closed sblatz closed 6 years ago
AsianLocaleTest and SearchProviderTest are resolved when https://github.com/mozilla-mobile/AutocompleteTextField/pull/6 lands in AutocompleteTextField, and we update Carthage. This also fixes the first failure of almost all the tests where they were failing hitting the settings button. Many more to go though.
Looks to me like SettingAppearanceTest is failing correctly (with the AutocompleteTextField update) because there is not, in fact, a cell for rating Focus. It is expecting it under the Mozilla section I believe. Should there be a cell for rating focus, or am I missing something else? @sblatz @Sdaswani
TrackingProtectionSettings & WebsiteMemoryTest are fixed with a combination of the AutocompleteTextField PR & https://github.com/mozilla-mobile/focus-ios/tree/oliviabrown9/fixes-TrackingProtectionSettings
WebsiteAccessTests is fixed with a combination of the AutocompleteTextField PR & https://github.com/mozilla-mobile/focus-ios/tree/oliviabrown9/fix-WebsiteAccessTests
@sblatz didn’t you add a cell for rating Focus in settings?
DragAndDrop is fixed with AutocompleteTextField PR & https://github.com/mozilla-mobile/focus-ios/tree/oliviabrown9/fix-DragAndDropTest.
Note: this test behaves unexpectedly if the app is not in full-screen mode (and depending on what other app is in full-screen mode). Might want to track this in another issue if we think it's important, but I don't think it should be a release-blocker for 6.0.
@sdaswani yes, I will fix this today.
Follow #993 for updates.
Tests: