search

mozilla-mobile / guardian-vpn-ios

Mozilla VPN for iOS
https://vpn.mozilla.org
Mozilla Public License 2.0
52 stars 16 forks source link

Task/pgios211 center onboarding screens #192

Closed connected-rkingsmill closed 4 years ago

connected-rkingsmill commented 4 years ago
Screen Shot 2020-03-16 at 11 06 44 AM Screen Shot 2020-03-16 at 11 08 06 AM Screen Shot 2020-03-16 at 11 09 10 AM Screen Shot 2020-03-16 at 11 22 04 AM Screen Shot 2020-03-16 at 11 14 01 AM Screen Shot 2020-03-16 at 11 14 58 AM
connected-crwilson commented 4 years ago

Everything looks centred now in both iOS 12.4.1 and 13.3.1 on both iPhones and iPads, but would we be able to add line-wrap or truncation to the titles of each onboarding screen? They're truncated on narrower devices - this is especially visible in German, shown in the screenshots below, with the observed results on an SE, then what the full titles look like on an iPad:

IMG_0084 IMG_0075 IMG_0076 1

connected-crwilson commented 4 years ago

Looks good to me now! I can confirm that the issue with the onboarding titles not truncating or wrapping to a new line has been fixed in the latest commit, and the titles now wrap onto a new line, as shown in the screenshot below:

IMG_0009

Thus, good to merge!