search

mozilla-mobile / guardian-vpn-ios

Mozilla VPN for iOS
https://vpn.mozilla.org
Mozilla Public License 2.0
52 stars 16 forks source link

Align onboarding page indicator with Get Started button #202

Closed connected-adietz closed 4 years ago

Paul-Huang-Connected commented 4 years ago

Looks good @connected-adietz ! Thank you for helping us with iOS defects :)

I am a little wary of the magic numbers like "-92 : -52" - is there a more adaptive way to align the UI elements than using the hard coded ints?

If you have time, can you also attach iPhone and iPad screenshots for this code change in this PR?

connected-adietz commented 4 years ago

@Paul-Huang-Connected I agree about the hardcoded numbers, however since the Get Started button is also hard coded in place this was the best way to directly align them. I am open to recommendations for more robust solutions!

connected-adietz commented 4 years ago

Screen Shot 2020-03-24 at 4 08 02 PM Screen Shot 2020-03-24 at 4 09 17 PM Screen Shot 2020-03-24 at 4 13 25 PM Screen Shot 2020-03-24 at 4 13 59 PM

Paul-Huang-Connected commented 4 years ago

Thanks @connected-adietz !

I am good with merging the PR. What are your thoughts @connected-rkingsmill ?