mozilla-mobile / guardian-vpn-ios

Mozilla VPN for iOS
https://vpn.mozilla.org
Mozilla Public License 2.0
52 stars 16 forks source link

Task/pgios 261 account model refactoring #204

Closed Paul-Huang-Connected closed 4 years ago

Paul-Huang-Connected commented 4 years ago

Also addressed:

[x] Merge URLrequest build and Guardian URL request classes: This extra layer of abstraction isn't valuable [x] Account vs. AccountManager: keep models simple and dumb [x] Move Codable Models to Models directory: why are we maintaining the difference here? [x] Create Persistence directory to house AccountStore and PersistenceLayer [x] Rename Singletons group to Managers [x] Move Connection health monitor to managers Convert model classes to structs [x]Remove all shared instances except for the dependency manager [x]Guardian Error vs Guardian API error [x] Break up NetworkingEnum class