search

mozilla-mobile / guardian-vpn-ios

Mozilla VPN for iOS
https://vpn.mozilla.org
Mozilla Public License 2.0
52 stars 16 forks source link

Try Mozilla VPN button does not take to the proper site #279

Closed isabelrios closed 3 years ago

isabelrios commented 3 years ago

Seen using latest build from develop bran on iPhone 8 (iOS 13.7 and 13.5) simulator. Also reproducible on latest stage build from TF on real device

Steps After log in using a stage account, on main view click on the Try Mozilla VPN button. On the new screen open click on the Try Mozilla VPN button at the bottom

Actual Nothing happens when clicking on that button Captura de pantalla 2020-10-28 a las 13 13 19

Expected Upon clicking on the button the correct site is open allowing user to try the VPN

rlr commented 3 years ago

This is the In-App purchases build. That button is supposed to trigger the purchase but something isn't set up right. Do you have experience to help set it up? Thanks!

madalincm commented 3 years ago

@rlr I reproduced this issue on a real device (Iphone SE, ios 13.1.2) using the build from test flight. Do we need to follow some special setup when setting the build on the device?

rlr commented 3 years ago

I think we need to finish setting up the subscription in app store connect. I'm trying to sort this out with releng.

image

rlr commented 3 years ago

@madalincm @isabelrios OK, the product ID was wrong in the backend. I was able to get it to work now although it wasn't super smooth. I had to sign off and back on after paying to get the VPN to work. Let me know how it goes for you. Thanks!

rlr commented 3 years ago

I think the issue in my case was the transaction took so long that I clicked away before it was done. Be patient once confirming the purchase. We probably need to add a processing spinner screen there.

isabelrios commented 3 years ago

thanks @rlr for fixing it so fast! :) for me it does not work yet but I see an error when clicking on that button, which is different from the previous behaviour. It may be because I'm using a simulator and not a real device. @madalincm was able to click on that button and complete the process on a real device although he found a few issues in the way that he will comment so that they are investiaged in case of real bugs.

madalincm commented 3 years ago

as @isabelrios mentioned I was able to complete the subscription. I started filling some issues where I will describe the other bugs I'm encountering.

rlr commented 3 years ago

fixed by the server side change + #285

I'll get a new build out to test flight