search

mozilla-mobile / mozilla-vpn-client

A fast, secure and easy to use VPN. Built by the makers of Firefox.
https://vpn.mozilla.org
Other
470 stars 114 forks source link

Language hsb not recognized #2004

Closed birdsarah closed 2 years ago

birdsarah commented 3 years ago

When running ./scripts/importLanguages.py I get the following error:

File /home/bird/Dev/mozilla/mozilla-vpn-client/src/../translations/hsb/mozillavpn_hsb.ts won't be updated: 
it contains translation but the target language is not recognized

cc @flodolo

┆Issue is synchronized with this Jira Task ┆Reporter: Data Sync

flodolo commented 3 years ago

@bakulf

Did this happen in the past for other locales? This one has been there for a very long time :-|

EDIT: for reference, it's been in there since February

bakulf commented 3 years ago

Both hsb (hsb_DE) and dsb (dsb_DE) are fully supported. The reason why you see that error is probably a missing configuration on your device. We have to investigate why that happens.

In the meantime I want to add that:

  1. probably you will see hsb/dsb languages in the client after the compilation (upper/lower sorbian).
  2. the error is generated by lupdate. We run the tool to see if there are strings not translated yet in the .ts file. This does not have side effects because both languages cover 100% of the strings.
  3. this does not happen in our github actions (I checked macos, linux, windows, android).
data-sync-user commented 2 years ago

➤ Andrea Marchesini commented:

See the last comments.