search

mozilla-mobile / mozilla-vpn-client

A fast, secure and easy to use VPN. Built by the makers of Firefox.
https://vpn.mozilla.org
Other
455 stars 110 forks source link

Switch to qt 6.5 [MacOS, Linux, Android, iOS] #3851

Closed data-sync-user closed 10 months ago

data-sync-user commented 2 years ago

TIMEBOX TO: 2 days

┆Issue is synchronized with this Jira Task ┆Reporter: Andrea Marchesini

data-sync-user commented 1 year ago

➤ Andrea Marchesini commented:

Wonder if we should jump to 6.4 directly

data-sync-user commented 1 year ago

➤ Beatriz Rizental Machado commented:

We will simply skip to 6.4. https://mozilla-hub.atlassian.net/browse/VPN-3321

data-sync-user commented 1 year ago

➤ Beatriz Rizental Machado commented:

Alright, reopening this issue because the 6.4 is not progessing nicely. There are a multitude of layout breakages. We are going to attempt the update to 6.3 to unblock whatever is blocked by this update and look at 6.4 after.

data-sync-user commented 1 year ago

➤ Sarah Bird commented:

This should probably be Qt 6.5 now.

data-sync-user commented 1 year ago

➤ Naomi Kirby commented:

We seem to have a lot of fragile QML right now that renders poorly on Qt 6.4, and I think that’s where the majority of the work will need to be. Currently these rendering problems are causing the most breakage on Ubuntu/23.04 Lunar. See: VPN-4494 ( https://mozilla-hub.atlassian.net/browse/VPN-4494 )

data-sync-user commented 1 year ago

➤ Basti commented:

Marking this as blocked:

We’re seeing the Windows Toolchain Task is not building QT.

It silently fails when it tries to invoke qsb (a qt binary we build) -

I’ve been trying: Diffrent Toolchains: (ming-gw, clang-cl, msvc), diffrent unpackers in case qsb cannot handle {{CL }} vs CLRF, diffrent source archives.

My current suspect is the Windows Version. Qt 6 requires Windows 10+, we are currently building on Windows Server 2012 aka Windows Server 8

I think this should be iceboxed for a bit, as releng is currenlty in the process of moving us to windows server 2022.

data-sync-user commented 1 year ago

➤ Valentina Virlics commented:

Basti could we have a fix version for this? I assume 2.18? and also if there is no QA needed here, the “qa-not-actionable“ label. Thank you!

data-sync-user commented 1 year ago

➤ Basti commented:

that was backed out, sorry!

data-sync-user commented 10 months ago

➤ Santiago Andrigo commented:

Tracking this work in VPN-5519

data-sync-user commented 4 months ago

➤ Santiago Andrigo commented:

Back to Cancelled

data-sync-user commented 3 months ago

➤ Santiago Andrigo commented:

Back to Cancelled