search

mozilla-mobile / mozilla-vpn-client

A fast, secure and easy to use VPN. Built by the makers of Firefox.
https://vpn.mozilla.org
Other
474 stars 114 forks source link

Expose all the languages in staging mode #5763

Closed data-sync-user closed 1 year ago

data-sync-user commented 1 year ago

Initially, I wanted to fix a crash in the wasm client, where we expose all the languages always. Missing translations in languages.json caused the crash. Those translations were generated from a Mozilla VPN client (non-wasm), where we include languages with more than 70% of completeness.

To fix this problem and to improve the entire client, I would like to see all the languages, even if uncompleted, in staging mode.

As usual, we keep languages with >70% completeness in production mode.

┆Issue is synchronized with this Jira Task ┆Reporter: Andrea Marchesini

data-sync-user commented 1 year ago

➤ Andrea Marchesini commented:

With this issue you will be able to see all the languages in staging mode. In production we keep languages with completeness higher than 70%.

data-sync-user commented 1 year ago

➤ Bianca Hidecuti commented:

Verified this on Mozilla VPN 2.14.0 (2.202302081253), across platforms, on stage server.

All languages are displayed in the client: sq, bg, co, cs, nl, en-CA, en-GB, fi, fr, fy, de, el, hu, is, id, ia, it, ja, oc, fa, pt-BR, pt-PT, pa-IN, ru, sk, dsb, hsb, es-AR, es-CL, es-MX, es-es, sv-SE, uk, cy, EXCEPT on iOS, where the following languages are not shown:

Also, the zh-CN and zh-TW langauges are now displayed as follows:

!Screenshot 2023-02-10 at 15.34.53.png|width=376,height=133!

Is it intended? Thank you.

data-sync-user commented 1 year ago

➤ Andrea Marchesini commented:

Putonghua is Standard Chinese used in People's Republic of Chinahttps://www.wikidata.org/wiki/Q24841726 ( https://www.wikidata.org/wiki/Q24841726|smart-link ) So, all good there!

For iOS, file a separate bug. The issue is about not creating the completeness file via qmake.

data-sync-user commented 1 year ago

➤ Bianca Hidecuti commented:

Andrea Marchesini, thanks for the confirmation!

Marking this verified as fixed.

Tracking issue for iOS: https://mozilla-hub.atlassian.net/browse/VPN-4162 ( https://mozilla-hub.atlassian.net/browse/VPN-4162|smart-link )