add "max_client_version" condition to the old "Get Started" tutorial when the new one comes into effect

[data-sync-user]

Once https://mozilla-hub.atlassian.net/browse/VPN-2492 and https://mozilla-hub.atlassian.net/browse/VPN-3368 are released, we need to make sure clients without the “recommended server” UI/feature aren’t showing the new “Get started” tutorial and ARE showing the old one. We can do this by adding a "max_client_version" condition to the old “Get started” tutorials manifest

┆Issue is synchronized with this Jira Task ┆Reporter: Santiago Andrigo

[data-sync-user]

➤ Matt Lichtenstein commented:

Andrea Marchesini this description makes sense, right?

[data-sync-user]

➤ Andrea Marchesini commented:

Yes! And the new get-started should use qmlpath only.

[data-sync-user]

➤ Bianca Hidecuti commented:

Santiago Andrigo / Andrea Marchesini, is this applying to 2.15 version? Asking because on the 2.15 version, if the “Recommended servers” option from Dev options is disabled, the “Getting started with VPN” toturial is not displayed at all in the client.

cc: Valentina Virlics

[data-sync-user]

➤ Matt Lichtenstein commented:

Bianca Hidecuti

The new “Getting started” tutorial requires client version 2.15 or higher AND for the “recommended servers” feature to be enabled (this should be by default after https://mozilla-hub.atlassian.net/browse/VPN-4438 ( https://mozilla-hub.atlassian.net/browse/VPN-4438|smart-link ) is completed, which will be in 2.15)

The old “Getting started” tutorial has a max client version of 2.14 so that users don’t ever see both “Getting started” tutorials

It would probably be more optimal to be able to show a tutorial if a feature is NOT enabled, that way we can have a client on 2.15+ show the old “Getting started” tutorial if for some reason (like in your case) the “recommended server” feature is not enabled. Andrea Marchesini correct me if I am wrong, but there is no way at the moment to enable an addon if a feature is NOT enabled.

[data-sync-user]

➤ Andrea Marchesini commented:

Matt Lichtenstein This is achievable easily:

• In the manifest, in the condition object, add a javascript property pointing to conditions.js (or a better name)
• in conditions.js implements something like:

(function(api, condition) { // use api.featureList.get('the feature name here') // we can also use api.connectSignal to monitor a featureList change // if the conditions meet, call: condition.enable(). When they don't, call: condition.disable() })

[data-sync-user]

➤ Matt Lichtenstein commented:

Andrea Marchesini Bianca Hidecuti in that case, I think we should sethttps://mozilla-hub.atlassian.net/browse/VPN-3368 ( https://mozilla-hub.atlassian.net/browse/VPN-3368|smart-link ) back to in-progress and have both the old and new “Getting started” tutorials ignore client version and just go based off of whether the “recommended servers” feature is enabled. Let me know if there are any objections

cc: Santiago Andrigo

[data-sync-user]

➤ Matt Lichtenstein commented:

Closing this ticket because an alternative solution was implemented as a part of VPN-3368

[data-sync-user]

➤ Santiago Andrigo commented:

Back to cancelled