search

mozilla-mobile / mozilla-vpn-client

A fast, secure and easy to use VPN. Built by the makers of Firefox.
https://vpn.mozilla.org
Other
462 stars 113 forks source link

Update the VPN client code to use smart pointers #6214

Open data-sync-user opened 1 year ago

data-sync-user commented 1 year ago

To avoid any memory leaks or dependency on Qt to delete anything that goes out of scope, we should be smart pointers (mostly shared and unique pointers).

┆Issue is synchronized with this Jira Task ┆Reporter: Gela Malek Pour

H-e-n-r-i commented 1 year ago

I am happy to do this. However, I am a newcomer, and the docs aren't too clear. there are so many files and folders, would I do this for all files in the src folder?

Gela commented 1 year ago

Thanks @H-e-n-r-i , yes I was specifically thinking of starting with triaging and updating all the code under https://github.com/mozilla-mobile/mozilla-vpn-client/tree/main/src/apps/vpn and https://github.com/mozilla-mobile/mozilla-vpn-client/tree/main/src/shared

Depending on the number of instances, this might be a large change so please feel free to break your work into smaller PRs by directory. I'd be happy to review and help you get your changes in.

H-e-n-r-i commented 1 year ago

Thanks @H-e-n-r-i , yes I was specifically thinking of starting with triaging and updating all the code under https://github.com/mozilla-mobile/mozilla-vpn-client/tree/main/src/apps/vpn and https://github.com/mozilla-mobile/mozilla-vpn-client/tree/main/src/shared

Depending on the number of instances, this might be a large change so please feel free to break your work into smaller PRs by directory. I'd be happy to review and help you get your changes in.

@Gela Thank you, I will begin on this shortly and ask for any help if needed!