[Windows] App exclusions set Config Failed: - An object with that GUID or LUID already exists.

[data-sync-user]

Important details: 

• this is reproducible if the browser is excluded when the VPN is already ON as well;
• no other VPNs are installed on the testing device;
• not reproducible on another Windows 11 device where the Nord VPN app is installed (the excluded apps are not protected);

Affected versions:

• 2.15.0 (2.202305041551); 

Tested Platforms:

• Windows 11;

Prerequisites: 

• Have a Fx account with an active subscription for Mozilla VPN;
• Have Mozilla VPN app installed and open;
• Be signed in;

Steps to reproduce:

1. Go to Settings - App exclusions screen;
2. Check the checkbox for any browser (e.g. Chrome, Firefox);
3. Turn ON the VPN;
4. Load an IP check web page using the excluded browser and observe the IP address;

Expected result:

• The real IP address is displayed;

Actal result:

• The IP address from the VPN server is displayed;

Notes:

• See the attached video and logs;

┆Issue is synchronized with this Jira Bug ┆Reporter: Bianca Hidecuti

[data-sync-user]

➤ Basti commented:

!Screenshot 2023-05-08 184526.png|width=1524,height=830!

Hey! I have issues reproducing this.

Maybe we have 2 issues here? I can 100% reproduce this when

→ Be Connected.

→ Go to Settings

→ Make One Change

→ Press Home Button

→ (Connection time was reset due to silent server switch)

So it seems the New Split Tunnel setting was not applied.

However if i:

→ Be Connected.

→ Go to Settings

→ Make One Change

→ Press Home Button

→ Disconnect -> Connect

Things seem to work. Can you confirm that the 2nd case is also not working for you?

[data-sync-user]

➤ Bianca Hidecuti commented:

Basti, the 2nd case is also not working for me - I am attaching logs.

!image_2023_05_09T08_35_32_177Z.png|width=961,height=550!

[^mozillavpn-2023-5-9.txt]

[data-sync-user]

➤ Basti commented:

Bianca Hidecuti Thank you for confirming-

Note for me: The error is in WindowsSplitTunnel::setRules however the Message “An object with that GUID or LUID already exists." Is the code we are getting from the Driver.

[09.05.2023 11:34:24.417] (WindowsSplitTunnel) Debug: New Network Config Applied

new State: 3 [09.05.2023 11:34:24.417] (WindowsSplitTunnel) Debug: Pushing new Ruleset for Split-Tunnel 3 [09.05.2023 11:34:24.417] (WindowsSplitTunnel) Debug: \Device\HarddiskVolume5\Program Files\Google\Chrome\Application\chrome.exe [09.05.2023 11:34:24.417] (WindowsSplitTunnel) Debug: \Device\HarddiskVolume5\Program Files\Mozilla Firefox\firefox.exe [09.05.2023 11:34:24.418] (WindowsUtils) Error: Set Config Failed: - An object with that GUID or LUID already exists. [09.05.2023 11:34:24.418] (WindowsSplitTunnel) Error: Failed to set Config err code 2150760457

[data-sync-user]

➤ Beatriz Rizental Machado commented:

Hey Bianca Hidecuti . Neither me or Basti were able to reproduce this issue. I have filed a PR, with Basti’s help, that is a hunch on what may be happening there. I’ll mark this as merged once that is uplifted to 2.15 🤞

Santiago Andrigo Matt Lichtenstein I believe this should not be a blocker for the 2.15. It looks like something specific to Bianca Hidecuti 's machine. There is definitely an issue here, however it is looking like an ege case. Would you mind lowering the priority here?

[data-sync-user]

➤ Bianca Hidecuti commented:

Hey Beatriz Rizental Machado,

We verified this on other 3 machines (Windows 10/Windows 11), and the only thing that is reproducing is the scenario mentioned by Basti below → apps are still protected when they are excluded from the list while the VPN is ON (not reproducing if apps are excluded while the VPN is OFF).

[data-sync-user]

➤ Beatriz Rizental Machado commented:

Bianca Hidecuti thank you so much for testing this! Okay, this adds weight to the hypothesis that this is an edge case then. When the VPN is turned ON, in order to for the app exclusions to be applied a connection reset is required. So, if you enable the exclusions while the VPN is OFF and then turn it on, that should work. While if you enable them while the VPN is ON and doesn’t restart the connection they shouldn’t work. I filed https://mozilla-hub.atlassian.net/browse/VPN-4761?atlOrigin=eyJpIjoiMTJmNWNiYmEzOWIzNGUwMjlhZGFiZWFkYTVhYWZkNzIiLCJwIjoiamlyYS1zbGFjay1pbnQifQ ( https://mozilla-hub.atlassian.net/browse/VPN-4761?atlOrigin=eyJpIjoiMTJmNWNiYmEzOWIzNGUwMjlhZGFiZWFkYTVhYWZkNzIiLCJwIjoiamlyYS1zbGFjay1pbnQifQ|smart-link ) as a UX bug, because we should inform the user that a connection reset is required.

[data-sync-user]

➤ Valentina Virlics commented:

Linking here the Linux ticket ( https://mozilla-hub.atlassian.net/browse/VPN-1990 ) as well, as the https://mozilla-hub.atlassian.net/browse/VPN-4761 ( https://mozilla-hub.atlassian.net/browse/VPN-4761|smart-link ) is not platform specific.

[data-sync-user]

➤ Bianca Hidecuti commented:

Verified this on the RC build - 2.15.0 (2.202305121612), while using Windows 11 and the following were observed:

• on my Windows 11 device - on which the issue was initially reported - the issue is still reproducing - attaching logs;
• on other Windows 11 device, the issue initially reported was not reproducing and the second case mentioned by Basti is fixed:
  • VPN ON - select Firefox/Chrome to be included in the protection list - real location is displayed on a check-IP web page ✅

Reopening this ticket since I am still able to reproduce the initial issue reported on my device, but we should lower the priority of the ticket based on the latest findings. What do you think Santiago Andrigo / Beatriz Rizental Machado ? Thank you.

[^mozillavpn-2023-5-15.txt]

[data-sync-user]

➤ Matt Lichtenstein commented:

Also tagging Naomi Kirby since she was involved as well ^

[data-sync-user]

➤ Santiago Andrigo commented:

Testing on Windows 11 with 2.15.0 (2.202305121612), I’m getting that app exclusions is still not working in any of the scenarios.

(the following happens from 12.37 PM onwards)

1. VPN is off → My IP (as per Firefox) is in Argentina
2. VPN is on without app exclusions → My IP (as per Firefox) is in Miami
3. Exclude ‘Firefox’, click ‘Back’ and verify that the connection timer restarted (implying a silent server switch) → My IP (as per Firefox) continues in Miami
4. Disconnect the VPN
5. Connect the VPN again → My IP (as per Firefox) is still in Miami.

Also:

• Verified that indeed we are excluding the right binary.
• Reproducing the same behavior on Chrome.

Attaching logs

[^app-exclusions-log.txt]

[data-sync-user]

➤ Beatriz Rizental Machado commented:

{quote}I’m getting that app exclusions is still not working in any of the scenarios.{quote}

Bianca Hidecuti please confirm this for me again… But IIUC this is only reproducible in one of your computers. Correct?

[data-sync-user]

➤ Beatriz Rizental Machado commented:

{quote}Exclude ‘Firefox’, click ‘Back’ and verify that the connection timer restarted (implying a silent server switch) → My IP (as per Firefox) continues in Miami{quote}

A timer restart doesn’t mean the exclusions were applied. You need to manually reset the connection. See https://mozilla-hub.atlassian.net/browse/VPN-4761 ( https://mozilla-hub.atlassian.net/browse/VPN-4761|smart-link ) . I even mentioned this:

{quote}It is even more confusing, because it looks like a reconnection takes place after changing app exclusions settings i.e. the timer is restarted.{quote}

[data-sync-user]

➤ Santiago Andrigo commented:

Update: Same situation with 2.14 😞

[data-sync-user]

➤ Santiago Andrigo commented:

Ok, just verified that after uninstalling Mullvad and rebooting, app exclusions is working again.

On 2.15, it works even after a silent server switch.

Was there a ticket specifically to remove access to the app exclusions functionality for folks who have installed the Mullvad client? Seems like there was a regression there.

[data-sync-user]

➤ Santiago Andrigo commented:

Downgrading to low as all evidence points to this being a corner case that is difficult to reproduce at this point.

[data-sync-user]

➤ Beatriz Rizental Machado commented:

{quote}Was there a ticket specifically to remove access to the app exclusions functionality for folks who have installed the Mullvad client? Seems like there was a regression there.{quote}

Not that I know of.

[data-sync-user]

➤ Bianca Hidecuti commented:

{quote}Bianca Hidecuti please confirm this for me again… But IIUC this is only reproducible in one of your computers. Correct? I was planning to discuss this on stand up today and lower the priority. AFAICT, this is a low priority issue.{quote}

Beatriz Rizental Machado, yes, this is only reproducible on my device (Win 11) and Valentina’s device (Win 10).

[data-sync-user]

➤ Valentina Virlics commented:

Santiago Andrigo Here ( https://mozilla-hub.atlassian.net/browse/VPN-3453 ) is the ticket that was initially logged and Basti thought it is happening because of other VPN split-tunneling. But we close it, in favor of this one, because we uninstalled the other VPN and the issue still reproduces.

[data-sync-user]

➤ Valentina Virlics commented:

“qa-wishlist” reason:

• important feature does not work on a testing device => blocks qa in testing the feature on Windows versions;