search

mozilla-mobile / mozilla-vpn-client

A fast, secure and easy to use VPN. Built by the makers of Firefox.
https://vpn.mozilla.org
Other
473 stars 114 forks source link

(Linux) build error 2 because CMake not set to check for linguist-qt6 #6899

Open marcel263 opened 1 year ago

marcel263 commented 1 year ago

Building fails on Linux (Fedora) because linguist-qt6 is not installed. Installing this package and running CMake again solves the issue.

During build, gmake fails with error 2 in target all. After much studying of the logs, it became clear that translations/CMakeLists.txt has custom heuristic on line 12 supposedly because CMake internal's is broken. However when user is not aware of requirement of lconvert-qt6, lupdate-qt6, lrelease-qt6, during configuration it fails silently and in translations/CMakeFiles/translations_vpn.dir/build.make there are placeholders like "QT_LCONVERT_EXECUTABLE-NOTFOUND". As such, sh gives error because this placeholder is not a valid command and also happens to be an invalid variable in sh. Generation of the languages fails subsequently after " Automatic RCC for".

Solution: fix checking dependency during configure and throw exception, clearly state build dependency in README.

┆Issue is synchronized with this Jira Bug

data-sync-user commented 1 year ago

➤ Betty Fleming commented:

Not 2.15 blocker

matthew-mcallister commented 1 year ago

Duplicate of https://github.com/mozilla-mobile/mozilla-vpn-client/issues/6789 (though with a better title).