Update/Welcome messages not displayed for Mozilla VPN version 2.16

[data-sync-user]

Important details:

• For previous versions (2.14) the “update to 2.15” message is displayed, updating from it installs the 2.16 version;
• For 2.15.x version no update message is displayed;
• For 2.16.x no welcome message is displayed;
• The \addons folder contains the “message_update_v2.16.rcc” file and inside it, max version for which the message should be displayed is 2.15.9;

Mozilla VPN used versions:

• 2.14/2.15.0/2.15.½.15.3/2.16/2.16.1;

Platform tested:

• all;

Prerequisites:

• Have a clean install of the Mozilla VPN;
• Have a production account with subscription for Mozilla VPN;
• Be logged in;

Steps to reproduce:

1. Have the 2.15.x version installed;
2. Go to Messages;
3. Observe the content;

Expected results:

• The update message is displayed. User is able to trigger and finalize with success the update.

Actual results:

• The update message is not displayed;

Notes:

• Update from “Check for updates“ still works;

┆Issue is synchronized with this Jira Bug ┆Reporter: Valentina Virlics

[data-sync-user]

➤ Matt Cleinman commented:

• Given that the upgrade message is missing from 2.15.x and the welcome message is missing from 2.16.x, it seems like the issue is with addons - and not our code that runs them. (Because 2.15.x presumably successfully had the welcome message)

  • The hash requested from releng was f36a57db6ba33836fd28d65e3bdbdc0ebcefd437

  • Looking at our codebase, the addons are pulled from: https://archive.mozilla.org/pub/vpn/addons/releases/latest/ ( https://archive.mozilla.org/pub/vpn/addons/releases/latest/|smart-link )

  • You can see the new addons in that URL.

  • Looking at log outputs from 2.16 on iOS.

  • So looks like it’s pulling older addons, as it doesn’t include the 2.16 what’s new message.

  • Looking into the addons index in the app - how is that updated?

  • From TaskAddOnIndex, which in turn gets in from the addon manifest: QString manifestUrl = QString("%1manifest.json").arg(AddonManager::addonServerAddress());

  • And as expected, this manifest file doesn’t include our new addons: https://archive.mozilla.org/pub/vpn/addons/releases/latest/manifest.json ( https://archive.mozilla.org/pub/vpn/addons/releases/latest/manifest.json )

  • This manifest file is not in our repo, so it’s built somewhere. Where is it built, and why isn’t it including our new files?

  • I believe it happens in scripts/addon/index.py, but some chance it’s in taskcluster/ci/beetmover/kind.yml or taskcluster/ci/build.addons.yml. And if for some reason it’s not there, the other places that mention the manifest file but I haven’t really looked into aretaskcluster/mozillavpn_taskgraph/transform/beetmover.py and taskcluster/scripts/addons/build.sh.

[data-sync-user]

➤ Matt Cleinman commented:

• scripts/addon/index.py is run in scripts/cmake/addons.cmake. This, in turn, is run in addons/CMakeLists.txt (line 15: include(${CMAKE_CURRENT_SOURCE_DIR}/../scripts/cmake/addons.cmake)).
  • We did change how we build addons in 2.16: https://mozilla-hub.atlassian.net/browse/VPN-4291 ( https://mozilla-hub.atlassian.net/browse/VPN-4291|smart-link ) .
  • I’m asking releng if we can get logs for the addons job, to see if anything jumps out there.

[data-sync-user]

➤ Matt Cleinman commented:

Naomi Kirby hopped in for a bit, thanks!

• It was correct in the RC (https://archive.mozilla.org/pub/vpn/addons/candidates/20230801121237/manifest.json ( https://archive.mozilla.org/pub/vpn/addons/candidates/20230801121237/manifest.json )), so perhaps it was an issue with the promotion to prod?

• Nope, it actually seems like it's correct in https://archive.mozilla.org/pub/vpn/addons/releases/20230801121237/manifest.json ( https://archive.mozilla.org/pub/vpn/addons/releases/20230801121237/manifest.json )

• However, it is wrong in https://archive.mozilla.org/pub/vpn/addons/releases/latest/manifest.json ( https://archive.mozilla.org/pub/vpn/addons/releases/latest/manifest.json )

• I’d expect those two files to match - Given https://archive.mozilla.org/pub/vpn/addons/releases/, ( https://archive.mozilla.org/pub/vpn/addons/releases/, ) it seems like latest should match 20230801121237.

• I can see in beetmover.py where it should be including the latest directory as part of the promotion to prod.

• I reached out to releng to assist, as it now seems like it is in their boat.

[data-sync-user]

➤ Matt Cleinman commented:

Looks like that latest directory’s manifest.json matches https://archive.mozilla.org/pub/vpn/addons/releases/20230524074709/manifest.json ( https://archive.mozilla.org/pub/vpn/addons/releases/20230524074709/manifest.json ). which is the last release. Interesting.

[data-sync-user]

➤ Matt Cleinman commented:

Naomi Kirby hopped in, @relduty, could we get some help with VPN addons?

• App isn't showing the latest update/upgrade messages, which is because the directory's manifest.json file doesn't include these messages (message_whats_new_v2.16, message_update_v2.16).
• It seems like it's correct in https://archive.mozilla.org/pub/vpn/addons/releases/20230801121237/manifest.json ( https://archive.mozilla.org/pub/vpn/addons/releases/20230801121237/manifest.json )
• However, those entries are missing in https://archive.mozilla.org/pub/vpn/addons/releases/latest/manifest.json ( https://archive.mozilla.org/pub/vpn/addons/releases/latest/manifest.json )
• Do you know why these two files don't match? Given https://archive.mozilla.org/pub/vpn/addons/releases/, ( https://archive.mozilla.org/pub/vpn/addons/releases/, ) it seems like latest should match 20230801121237, right?

For some reason the 2.16 version of addons index (manifest.json) in the latest directory got over written with the 2.15 version about 20 minutes after it was promoted. Releng re-ran the job, and latest now has the manifest we’d expect. Releng is currently looking into why it was overwritten previously, and I’m keeping an eye on it to make sure it doesn’t revert again. But as of now, this is done.

[data-sync-user]

➤ Matt Cleinman commented:

So, it reverted again, so this is not fixed.

Rel eng pulled in some more folks, seems related to how we sync changes across a couple cloud providers. Hoping it is fixed tomorrow, but this is mostly happening outside the VPN team at this point.

[data-sync-user]

➤ Valentina Virlics commented:

Verified this across platforms and left a short report via Slack. Add-ons seem to have been pushed out with success.

There is still a question regarding the welcome message.

• “You’ve updated Mozilla VPN” message is displayed after fresh install as well - @Matt Cleinman ( https://mozilla.slack.com/team/U046U6BUPRR ) is this behavior correct? did we replaced the welcome message with the “You’ve updated Mozilla VPN” with 2.16?

[data-sync-user]

➤ Matt Cleinman commented:

Per Santiago Andrigo on slack, he is comfortable with this change. Moving this to done, feel free to move back if you disagree.

[data-sync-user]

➤ Valentina Virlics commented:

Matt Cleinman Santiago Andrigo So, going fwd, starting with 2.16, we will no loger have the Welcome message anymore at fresh installs? But instead we will be using the “You’ve updated Mozilla VPN“ everywhere? Thank you!

[data-sync-user]

➤ Santiago Andrigo commented:

Yes, one replaces the other. Note that the message should include the changelog, just as much and to the extent as the “Update” / “Download” message does.