Handle unexpected termination of the windows tunnel service

mozilla-mobile / mozilla-vpn-client

A fast, secure and easy to use VPN. Built by the makers of Firefox.

https://vpn.mozilla.org

Other

455 stars 110 forks source link

Handle unexpected termination of the windows tunnel service #7987

Closed data-sync-user closed 6 months ago

data-sync-user commented 1 year ago

The windows tunnel broker service acts as a middle-man between the client GUI and the wireguard-go tunnel device, while we hope that the wireguard-go code is stable and free of crashes, we should ensure that a crash of the wireguard-go tunnel device does not result in a broken network connection. In the event of a crash:

The tunnel broker safely cleans up the network interfaces and deactivates the connection.
Normal routing via the user’s default internet gateway is restored.
The user’s default DNS server is restored.
A deactivate signal is passed up to the GUI.

┆Issue is synchronized with this Jira Task ┆Reporter: Naomi Kirby

data-sync-user commented 6 months ago

➤ Naomi Kirby commented:

Bringing this one into the Zapdos sprint, because it kind of came along for free with VPN-4227

data-sync-user commented 6 months ago

➤ Raluca Monica Ilban commented:

Hi Naomi Kirby , could you please let us know how we can test this? As mentioned in https://mozilla-hub.atlassian.net/browse/VPN-4227 ( https://mozilla-hub.atlassian.net/browse/VPN-4227|smart-link ) , we cannot use the 'force_daemon_crash' command in Inspector, only restart the vpn broker from windows service manager.

data-sync-user commented 6 months ago

➤ Naomi Kirby commented:

My steps to test this:

Open the VPN client, sign in
Activate the VPN
Open the windows service manager, locate the Mozilla VPN (tunnel) service, stop the service and close the service manager. This should cause the VPN client to disconnect, and a background service error banner may be displayed.
Check that the internet is still reachable and that the system appears to be remain functional.
Re-activate the VPN, it should connect as normal.

data-sync-user commented 6 months ago

➤ Raluca Monica Ilban commented:

Hi Naomi Kirby ,

Thank you! We've verified this while using build 2.21.0 (2.202403072017) in Windows 10/11, following the steps provided and we confirm that the VPN can be turned on successfully after the Mozilla VPN (tunnel) service was stopped. Marking this as fixed.