[l10n] What’s new message is displayed in the client for languages that are not fully translated

[data-sync-user]

Important details:

• +Pontoon+ shows the translation percentage at 100%, but for the content of the message before the fix for +VPN-5745+;
• this is not reproducing for languages ​​where the old message has not been fully translated (e.g. bulgarian); 

Affected versions:

• 2.18.0 (2.202310241849)

Tested Platforms:

• macOS 12.6.6;

Prerequisites:

• Have Mozilla VPN app installed and open;

• Have a Mozilla account with an active subscription;

• Be signed in;  

• Have the language set to German;

Steps to reproduce:

1. Go to Messages and observe the “You’ve update to Mozilla VPN 2.18” message;

Expected result:

• The message is not displayed as it is not fully translated;

Actual result:

• The message is displayed and the content of it shows strings in both EN and DE; 

Notes:

• See the attached ss;

┆Issue is synchronized with this Jira Bug ┆Reporter: Bianca Hidecuti

[data-sync-user]

➤ Bianca Hidecuti commented:

Still reproducing using the latest RC - the message contains strings in both EN and DE.

!Screenshot 2023-10-30 at 16.19.53.png|width=395,height=762!

[data-sync-user]

➤ Matt Cleinman commented:

Short versionThis should be working now. I’ve manually updated our translation repo, which should fix this for now. As Bea earlier guessed, this is an artifact of the quick turn around between string updates and RC - and why we should try to better respect the string freeze when possible.

Details on root cause in the next session, and considerations for a long term fix is in the third section.

Root causeThis is the same root cause as the “showing string IDs” bug (recently fixed by always falling back to English in https://github.com/mozilla-mobile/mozilla-vpn-client/pull/8266/ ( https://github.com/mozilla-mobile/mozilla-vpn-client/pull/8266/|smart-link ) ). For a moment I thought this change caused this, but instead it’s the same root cause:

• It’s not skipping the addon because it believes the completeness for that language is 1.0 (and it would skip anything smaller)
• To be clear: The issue is when we write the translations.completeness file
• The translations.completeness counts the targets and sources in each language's .xliff file, and uses that ratio to determine the completeness
• However, at this point the .xliff doesn’t have the new translation strings (aka targets), and so it calls it 100% translated erroneously

This is because the testing/RC is moving quicker than the strings do, as they can take up to 5 days or so - there are two PRs that need to happen to get everything working for addons:

1. We add strings into our codebase (in this case, Oct 27 ( https://github.com/mozilla-mobile/mozilla-vpn-client/pull/8397 ))
2. Extract new strings and update all locales job is run, and merged into the translations repo (happened Oct 30 in this case ( https://github.com/mozilla-l10n/mozilla-vpn-client-l10n/pull/405 ), it’s set to run Mon-Thurs at 7am)
3. We update our codebase with the new translations (runs daily at 0600 UTC, next scheduled time is Oct 31 - but I’m running manually now and coming in as https://github.com/mozilla-mobile/mozilla-vpn-client/pull/8427 ( https://github.com/mozilla-mobile/mozilla-vpn-client/pull/8427|smart-link ) )

Long term solutions[currently writing]

[data-sync-user]

➤ Matt Cleinman commented:

This ticket is for the work for 2.18 RCs. I’ve created another ticket to consider the long term changes (if we want to make them): https://mozilla-hub.atlassian.net/browse/VPN-5785 ( https://mozilla-hub.atlassian.net/browse/VPN-5785|smart-link )

[data-sync-user]

➤ Bianca Hidecuti commented:

Verified this as fixed while using the latest RC for addons. What’s new/Update/Download messages are displayed in the client only for languages that are fully translated, without showing mixed strings.

Attaching postfix ss.

!Screenshot 2023-10-31 at 09.09.02.png|width=364,height=667!