Mozilla VPN is blocked in “Disconnecting…” state after trying to connect to an unavailable server

mozilla-mobile / mozilla-vpn-client

A fast, secure and easy to use VPN. Built by the makers of Firefox.

https://vpn.mozilla.org

Other

442 stars 103 forks source link

Mozilla VPN is blocked in “Disconnecting…” state after trying to connect to an unavailable server #8629

Open data-sync-user opened 7 months ago

data-sync-user commented 7 months ago

Important details:

Force-quitting/sign-out the client removes the blocking state;
Not reproducing on Linux, Android and iOS;

Mozilla VPN used versions:

2.19.0 (2.202311221018) - RC build;

Platform tested:

Windows 10;
MacOS 12/14;

Prerequisites:

Have an account with subscription for Mozilla VPN;

Steps to reproduce:

Log in with the accounts from prerequisites;
Have the VPN OFF and “Vienna” as selected location;
Open the Inspector and run “force_server_unavailable”;
Go to client and try to turn the VPN ON;

Expected result:

A server unavailable modal is displayed;

Actual result:

VPN remains blocked in “Disconnecting…” state;

Notes:

Reproducing on both MacOS and WIndows;

┆Issue is synchronized with this Jira Bug ┆Reporter: Valentina Virlics

data-sync-user commented 7 months ago

➤ Bianca Hidecuti commented:

We were able to experience a server not being available without triggering it via Inspector, and the issue is not reproducible → the modal is displayed and the user is not stuck in Disconnecting state.

data-sync-user commented 7 months ago

➤ Santiago Andrigo commented:

Categorizing as Medium as it’s an Inspector-Only issue, but we still need to address this, because otherwise this troubleshooting tool loses it’s value.

data-sync-user commented 5 months ago

➤ Bianca Hidecuti commented:

Still reproducing with Mozilla VPN 2.20.0 (2.202401140639).

data-sync-user commented 5 months ago

➤ Gela Malek Pour commented:

I think adding a check for state == StateDisconnecting in serverUnavailable() here ( https://github.com/mozilla-mobile/mozilla-vpn-client/blob/main/src/controller.cpp#L293 ) should resolve this.

data-sync-user commented 4 months ago

➤ Beatriz Rizental Machado commented:

{quote}Categorizing as Medium as it’s an Inspector-Only issue, but we still need to address this, because otherwise this troubleshooting tool loses it’s value.{quote}

Although this is easier to reproduce with the inspector, this is not a inspector only issue. I have experienced this multiple times on MacOS with an actual unavailable server.

data-sync-user commented 2 months ago

➤ Valentina Virlics commented:

This is also reproducing while using Mozilla VPN 2.22.0 (2.202404222212).